-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding register option into login page #145
Comments
Hi, The underlying authentication system supports registration, however the standard provided login UI box does not. Are you using a custom login box ? If so then I can show you how to implement this. FYI: I released It adds |
I could add support for this, but not sure when I have time for this. |
No, we are using the default login box. Maybe we only need to add one other input field in client configuration, in addition to username and password. We develop an adapter for AuthServiceProvider which uses a remote account to authenticate. |
Currently, adding a button to the configuration doesn't really do anything. The dialog needs to be changed in the following way:
Just use the |
I think it is misunderstood, I mean that we did not write an adapter for login page. We have Username, Password, and one additional Domain input filed in login page. So as I understand, the login and register page/from are the same and the user can choose whether login button or register button. A different page/form is not loaded for the user registration.
Fortunately we are not in hurry if you plan to add this option. |
Correct. This was my thought.
It could be changed to have to views: login and registration. But this would involve a lot of changes because of how it is designed because of the configuration options to change the layout. I think I might just rewrite the login UI and export this as a class that can be inherited to change both the behavior and layouts instead of the configuration (and have some backward compatibility for it all).
Great. If you have some ideas or requirements put them here and I will take it into consideration when I start looking at this. |
Thanks a lot, I will leave my ideas here if there is any. |
Hi.
I plan to add register option into login page, so the registered user can login into OSjs desktop with his/her new account.
What changes do I need to apply and which files need to be modified?
The text was updated successfully, but these errors were encountered: