Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be great to be able to copy/move files between folders #7

Open
valp124 opened this issue Oct 17, 2019 · 14 comments
Open

It would be great to be able to copy/move files between folders #7

valp124 opened this issue Oct 17, 2019 · 14 comments
Assignees
Labels
enhancement New feature or request

Comments

@valp124
Copy link

valp124 commented Oct 17, 2019

Seems to be unavailable currently (no copy/paste buttons in the context menu). Drag and drop is possible but results in no action.

@andersevenrud
Copy link
Member

I have a somewhat working clipboard solution ready, so I guess this would be a good place to test it out 😊

@andersevenrud
Copy link
Member

I've started work on this and opened the following pull requests:

@andersevenrud
Copy link
Member

FYI I actually found a bug in the copy/move functionality in the server. So I'd advice upgrading @osjs/server :)

@valp124
Copy link
Author

valp124 commented Oct 18, 2019

Thanks for the heads up!!

andersevenrud added a commit that referenced this issue Dec 7, 2019
* Added state aware 'Edit' menu to toolbar
* Added copy/cut and paste options to edit context menus (#7)
@andersevenrud
Copy link
Member

@valp124 @josephjeno

If you update @osjs/client and @osjs/filemanager-application you should now be able to copy/cut and paste files via the context menu as well as a new Edit menubar item :)

andersevenrud added a commit that referenced this issue Dec 7, 2019
@andersevenrud
Copy link
Member

I also just pushed another update of @osjs/filemanager-application that adds in proper drop support.

@valp124
Copy link
Author

valp124 commented Dec 7, 2019

What an awesome dude you are!!

@josephjeno
Copy link

@andersevenrud ah this is awesome!

I've noticed when slightly moving a file and releasing, I receive an alert about source and destination being the same. It's just a minor annoyance, but can this alert be squashed? I am triggering it a lot just from touching files a bit, also maybe I'm too click-happy.

image
image

@andersevenrud
Copy link
Member

@josephjeno Aha. I'll add a check to prevent this :)

@andersevenrud
Copy link
Member

@josephjeno Just published an update that takes care of this. Thanks!

andersevenrud added a commit that referenced this issue Dec 10, 2019
@valp124
Copy link
Author

valp124 commented Dec 10, 2019

Thank you so much, Anders, from both @josephjeno and me!!

And since we're on the subject ... :) No urgency at all, these would be bells and whistles, but it'd be super convenient to be able to do two more things:

  1. Drag and drop files into a folder within the same window, as such

image

  1. Drag and drop folders (in addition to files), either to other folders or to the desktop, as such

image

(I suppose, dragging to the desktop would then create a shortcut rather than a copy.)

Again, these are more ideas than requests, not critical at all!

@andersevenrud
Copy link
Member

Drag and drop files into a folder within the same window, as such

I'll look into it. The UI component should support this 🤔

Drag and drop folders (in addition to files), either to other folders or to the desktop, as such

I'm not sure why I disabled dragging of folders.... but I've got a hunch that folder copy was not supported when I first added DnD. So I'll look into this again now that it most likely works just fine.

The desktop icons should support folders just fine as well since this is using the underlying VFS. I even see in the code that there's a conditional to open folders using File Manager :)

(I suppose, dragging to the desktop would then create a shortcut rather than a copy.)

It's possible to hold shift when dropping to get a contextmenu for creating shortcuts instead of copy on the desktop. However I've seen some issues relating to this that I'll look into.

@andersevenrud
Copy link
Member

(I suppose, dragging to the desktop would then create a shortcut rather than a copy.)

But having folders as shortcuts by default is probably a good idea 👍

@valp124
Copy link
Author

valp124 commented Dec 10, 2019

Right, exactly, open File Manager when double-clicking on a folder! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants