Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toString methods should return something that's more readable #7

Open
jamsden opened this issue Aug 31, 2020 · 7 comments
Open

toString methods should return something that's more readable #7

jamsden opened this issue Aug 31, 2020 · 7 comments
Assignees
Milestone

Comments

@jamsden
Copy link
Member

jamsden commented Aug 31, 2020

Project should be its title for example.

@jadelkhoury jadelkhoury added this to the DemoReady milestone Aug 31, 2020
@jadelkhoury jadelkhoury self-assigned this Aug 31, 2020
@jadelkhoury
Copy link
Member

Just to get started, I have now changed toString() to be "identifier (shortTitle)".
Identifier is always there. ShortTitle is somethere there. So at least we have something to show to start with.

BUT, I just realised that unless we create and store Links (a reified resource) instead of URIs, it will not be possible to display the label, instead of hte URI.
Alternatively, I need to do a GET on each property of a resource, in order to be able to display it.

Is it worth it?

@jamsden
Copy link
Member Author

jamsden commented Sep 9, 2020

Jad, I would prefer title | identifier, never both - that is prefer title if it exists, otherwise use identifier. This keep the UI logical and clean unless the information isn't available.

@jadelkhoury
Copy link
Member

Sure. It can be easily changed now that I have a system in place. I guess you mean “shortTitle” instead of title.
And also note that shortTitle doesn’t exist in the source. I had to add it from another property.

@jadelkhoury
Copy link
Member

So, I can now show something other than the URIs on the query page.

Once we have more relevant content (currently only identifier seems to have a value), I will update the toString() to be shortTitle.

@jadelkhoury
Copy link
Member

I happened to just push a change to master.
Based on what's being deployed, let's see what more we need to do on this issue.

@jamsden
Copy link
Member Author

jamsden commented Oct 5, 2020

You can code for shortTitle and if its not there use identifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants