Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong NS links #265

Open
12 of 17 tasks
berezovskyi opened this issue Sep 12, 2019 · 18 comments
Open
12 of 17 tasks

Wrong NS links #265

berezovskyi opened this issue Sep 12, 2019 · 18 comments
Assignees
@berezovskyi
Labels
Area: NS Priority: High

Comments

@berezovskyi
Copy link
Member

berezovskyi commented Sep 12, 2019 •
edited
Loading

Problems identified:

  • some folders have stray files (eg Core has core-vocab and core files)
  • some folders should not have been published (eg /config has no corresponding PSD)
  • some folders have unapproved vocabs in them (eg CM)

https://github.com/oslc-op/website-content-negotiation

https://github.com/oslc-op/website/tree/master/content/ns

TODOs
@berezovskyi berezovskyi self-assigned this Sep 12, 2019
@berezovskyi
Copy link
Member Author

The following files match the current NS folder and the archive:

b38c78a0cf5ddb9ee7370747285c888a90e23ed9  ./basicProfile/ldbp.rdf
a95ad96ee50e70552f2c09037405f3afe22f2bc2  ./cm/cm.rdf
6eb60dac7c98615b1f339ef14f68f36ead7bc680  ./ems/ems.rdf
8f68041afab51a2ce6acbb4ec929774f1b67f77f  ./qm/qm.rdf

The rest do not match. These are the differing files for the specs that were in the archive:

508dc70c88ceaf08a5816a336bd082b489f7175c  ./am/architecture-management-vocab.rdf
c99119aa823430dd7588477b620b32ce8802dc44  ./asset/asset-management-vocab.rdf
e03926db4c1b4e240e6618c18294a72df58993cc  ./rm/requirements-management-vocab.rdf
08475fab4c6d56e33ea8d8ce6609ce64e99ce60c  ./cm/change-mgt-vocab.rdf

Newly added (RDF/XML) files:

2db81dc4f955d38f53f903b38c9724594946cd97  ./auto/automation-vocab.rdf
895f0dd2df4e76acc0300bdc2e606746d4be87da  ./config/config-vocab.rdf
0e3b8e1d37d4a7066f8272d91ba3a31aa26c5413  ./core/core-vocab.rdf
3e515f188f08a1279c19488d164fc99b9c212b0a  ./core/core.rdf
5d081a82416ff90f3ab6ca32892466d517378ef9  ./perfmon/performance-monitoring-vocab.rdf

The only RDF/XML file in the specs repo is RM:

3eca6f0b11356c84706db3eb97ea5e7d2ac03ccf  ./rm/rm_2.0.rdf

SHA1 checksums were used.

cc @jamsden

@berezovskyi
Copy link
Member Author

Okay, so the ./core/core.rdf mystery: it was used in the .htaccess file previously

@berezovskyi
Copy link
Member Author

Now, AM:

$ cdiff -b am/architecture-management-vocab.rdf ../../misc/ns.old/am/am.rdf

$ rdfdiff am/architecture-management-vocab.rdf ../../misc/ns.old/am/am.rdf RDF/XML RDF/XML
am/architecture-management-vocab.rdf ../../misc/ns.old/am/am.rdf RDF/XML RDF/XML null null
models are equal

The old file will be restored to avoid confusion and cneg repo updated accordingly.

@berezovskyi
Copy link
Member Author

Same for asset mgt:

└─[$] <git:(master)cdiff -b content/ns/am/architecture-management-vocab.rdf misc/ns.old/am/am.rdf
diff: content/ns/am/architecture-management-vocab.rdf: No such file or directory
└─[$] <git:(master)> rdfdiff content/ns/asset/asset-management-vocab.rdf misc/ns.old/asset/asset.rdf RDF/XML RDF/XML
content/ns/asset/asset-management-vocab.rdf misc/ns.old/asset/asset.rdf RDF/XML RDF/XML null null
models are equal

@berezovskyi berezovskyi mentioned this issue Sep 14, 2019
Closed
@berezovskyi
Copy link
Member Author

  • Updated all XML files except for TRS (Turtle for Config).
  • Regenerated old Turtle/JSON-LD files with Jena 3.12
  • Generated N-Triples for all vocabs

@ndjc
Copy link
Member

ndjc commented Sep 30, 2019

The vocabulary links from open-services.net/ns are still wrong. They now redirect to the specs, or to a page that in turn contains links only to the specifications, and not to the vocabularies.

For example, if I go to open-services.net/ns/rm, I get redirected to https://archive.open-services.net/bin/view/Main/RmSpecificationV2a8d9.html. That is not the vocabulary - indeed, it doesn't even have a link to the vocabulary. To find that, I have to manually click on the RM Home button on the breadcrumbs at the top of the page, from there follow the link to the new wiki, and then click on the link to the RM 2.0 vocab at https://archive.open-services.net/bin/view/Main/RmVocabulary.html#.

Similarly, if I just go to open-services.net/ns, I get a page of spec listings, with links that claim to be to the vocabularies, but in fact point to the shape tables in the specs (this is really a separate issue - the vocab links on that page https://open-services.net/specifications/vocabularies/ are all incorrect).

@berezovskyi
Copy link
Member Author

berezovskyi commented Sep 30, 2019 via email

@berezovskyi
Copy link
Member Author

Will fix tomorrow at it requires redeploy of the content neg app

@berezovskyi
Copy link
Member Author

@jamsden @ndjc please go over https://open-services.net/specifications/vocabularies/ and give me a set of actions to do.

@ndjc
Copy link
Member

ndjc commented Feb 12, 2020

I've completed the initial verification of the RDF vocabulary pages at open-services.net, and I've found quite a few inconsistencies or errors that need to be addressed. Some will need discussion. See the attached note.
OSLC V2 Vocabulary Status.docx

@berezovskyi berezovskyi mentioned this issue Jul 17, 2020
Closed
4 tasks
@ndjc ndjc self-assigned this Sep 17, 2020
@berezovskyi berezovskyi removed their assignment Oct 30, 2020
@berezovskyi
Copy link
Member Author

berezovskyi commented Mar 18, 2021 •
edited
Loading

@ndjc in https://github.com/oslc-op/oslc-admin/blob/master/minutes/2021/2021-03-18.md#ns-deploy we agreed to publish vocabs+shapes for all specs as soon as they hit PS stage. This renders old vocab recovery efforts obsolete for: Core, RM, CM, QM, and Query. Please advise on actions needed to recover the right files and redirects for the other specs that are still published incorrectly.

@ndjc
Copy link
Member

ndjc commented Mar 18, 2021

Once we rule out Core, RM, CM, QM, and Query, the only remaining two issues are minor (an outdated RDF vocabulary source for AM, and a broken link for Asset Management) are both minor; I'm OK with closing this entire issue as won't fix.

@berezovskyi berezovskyi assigned berezovskyi and unassigned ndjc Mar 18, 2021
@berezovskyi
Copy link
Member Author

a broken link for Asset Management

do you have the right one?

an outdated RDF vocabulary source for AM

OK, we can update it when it goes to PS. @jamsden no objections?

@jamsden
Copy link
Member

jamsden commented Mar 18, 2021

none

@ndjc
Copy link
Member

ndjc commented Apr 8, 2021

re the asset management issue, my note says:

https://archive.open-services.net/wiki/asset-management/OSLC-Asset-Management-Vocabulary/index.html# is correct, but the link in that page to the RDF version of the file is broken - it just refers back to itself, the HTML page.

so if I go to open-services.net/ns/asset#, it redirects correctly to https://archive.open-services.net/wiki/asset-management/OSLC-Asset-Management-Vocabulary/index.html#. That page then states:

Following W3C best practices, this information is available in HTML format (this page) and in RDFS format.

The second link is a bad one - it points back to the same page. Later in the page, there is a more correct reference to https://archive.open-services.net/ns/asset/asset.rdf, which works correctly.

In other words, this is a content error in the original open-services.net wiki content, and is nothing to do with current open-services redirects. Since this issue was originally about correcting references to existing old content, and since we're not currently working on asset management, I see no urgency to fix this defect in the original content.

@berezovskyi
Copy link
Member Author

I have updated the vocabs in #287 but did not update the link in the https://github.com/oslc-op/website-content-negotiation/blob/master/negotiation.js#L45. Please check if we want to update it but then it's not really an errata but instead lowering the bar even further down to a PSD.

@berezovskyi
Copy link
Member Author

@ndjc thanks for catching that. I am fairly certain we don't want the link to point to https://archive.open-services.net/ns/asset/asset.rdf but https://open-services.net/ns/am/am.rdf (does not work now because it's not handled by nginx but the conneg server but we can fix it if needed) or replace the asset.rdf with a new asset.ttl or the newly generated asset.rdf

Wait a second! I though we were updating the AM vocab, not Asset!

@berezovskyi
Copy link
Member Author

The vocabs have been updated, shapes were added and vocab/shape page links were updated in oslc-op/website-content-negotiation#10, #292, #290, #293, #289

curl tests passed for all content-types:

Running production tests
Running tests on 'ns/core'
Running tests on 'ns/core/shapes/3.0'
Running tests on 'ns/cm'
Running tests on 'ns/cm/shapes/3.0'
Running tests on 'ns/rm'
Running tests on 'ns/rm/shapes/2.1'
Running tests on 'ns/qm'
Running tests on 'ns/qm/shapes/2.1'
Running tests on 'ns/config'
Running tests on 'ns/am'
Running tests on 'ns/asset'
Running tests on 'ns/auto'
Running tests on 'ns/perfmon'
ALL TESTS PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berezovskyi berezovskyi

Labels
Area: NS Priority: High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@berezovskyi @jamsden @ndjc