-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If no housenumber is entered or found, the area for moving the pin is too small #129
Comments
The functionality probably was added only recently after #89 ? In cases like the "Camino Chueco", the marker is placed around the middle of the way that Nominatim returned. But there is a second way to the east going south, so this part hasn't been included in the calculation of the mid-point. In cases where only a city was entered or found (maybe because the street name is missing in OSM) the area to drag the pin is quite large, but there is another problem: #127 |
This should be resolved with the changes I made in #137. Please let me know if you're still running into problems. |
Thanks for working on this! I just tried the random "Camino Chueco, Santa Fe" from the original post. But as you can see in the screenshot, the street of that name is not completely inside the bounding box: In the data, the street is divided into two ways, and the other one is not inside the bounding box. |
That's a limitation of Nominatim. This is the bounding box that they give back to us. I guess we could find a bounding box for the city instead? Or suggest that the user search for the city instead of just the street? |
Example:
This may also lead to bad entrys and misplaced notes.
The text was updated successfully, but these errors were encountered: