Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no housenumber is entered or found, the area for moving the pin is too small #129

Closed
daganzdaanda opened this issue Nov 2, 2023 · 4 comments

Comments

@daganzdaanda
Copy link

Example:

  • For the first geolocation, enter "Camino Chueco, Santa Fe" or even with any housenumber like "26, Camino Chueco, Santa Fe"
  • The street will be found, the pin will be set on some part of it
  • The circle to move the pin is much to small to reach all of the street

This may also lead to bad entrys and misplaced notes.

@daganzdaanda
Copy link
Author

The functionality probably was added only recently after #89 ?
It looks like a bit of finetuning could be helpful.

In cases like the "Camino Chueco", the marker is placed around the middle of the way that Nominatim returned. But there is a second way to the east going south, so this part hasn't been included in the calculation of the mid-point.
Would it be possible to add all the parts and return an area that encompasses the whole of the street?
Then the user could move the pin easily to the correct place.

In cases where only a city was entered or found (maybe because the street name is missing in OSM) the area to drag the pin is quite large, but there is another problem: #127

@iandees
Copy link
Member

iandees commented Jan 29, 2024

This should be resolved with the changes I made in #137. Please let me know if you're still running into problems.

@iandees iandees closed this as completed Jan 29, 2024
@daganzdaanda
Copy link
Author

Thanks for working on this!

I just tried the random "Camino Chueco, Santa Fe" from the original post.
It it cool that you can see the bounding box, was that there before?

But as you can see in the screenshot, the street of that name is not completely inside the bounding box:
image

In the data, the street is divided into two ways, and the other one is not inside the bounding box.

@iandees
Copy link
Member

iandees commented Jan 31, 2024

That's a limitation of Nominatim. This is the bounding box that they give back to us. I guess we could find a bounding box for the city instead? Or suggest that the user search for the city instead of just the street?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants