Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send validator sync update messages on changing validator set #88

Closed
Tracked by #85
ethanfrey opened this issue Jun 28, 2023 · 1 comment · Fixed by #109
Closed
Tracked by #85

Send validator sync update messages on changing validator set #88

ethanfrey opened this issue Jun 28, 2023 · 1 comment · Fixed by #109
Assignees
Milestone

Comments

@ethanfrey
Copy link
Collaborator

Currently we only sync the original validator set but do not send new messages when it changes.

To do so, we need more callbacks from the SDK osmosis-labs/mesh-security-sdk#47

Once that is complete, we need to adapt the contracts to it and propagate the proper ibc packets.

@maurolacy
Copy link
Collaborator

maurolacy commented Aug 21, 2023

This also requires storing the historical validator set on the Provider. Because slashing evidence is provided and would have to be checked at a given height.

At least unbonding period historical data need to be stored. This also raises the issue of pruning / deleting of old data, which is not simple to do with the data structures that we have currently implemented (i.e. SnapshotMap).

Alternatively to sending validator set updates and storing the deltas on the Provider, perhaps the historical validator set (or specific validators data) can be queried from the Consumer. If this can be done efficiently, the need for storing the historical Consumer's validator set(s) on the Provider can be obviated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants