Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TechDebt] Re-enable Astroport integration test for candidate routes #258

Open
p0mvn opened this issue May 26, 2024 — with Linear · 0 comments
Open

[TechDebt] Re-enable Astroport integration test for candidate routes #258

p0mvn opened this issue May 26, 2024 — with Linear · 0 comments

Comments

Copy link
Member

p0mvn commented May 26, 2024

Our Astroport PCL integration test for candidate routes test_astroport_tokens proved to be flaky.

Investigations pointed at the fact that sometimes the top liquidity Astroport PCL pool contains uosmo and another token (e.g. AXL)

However, due to pairing with uosmo (a token that is in many pools), the candidate route algorithm would not iterate far enough to reach the PCL pool.

In this specific example, the chosen candidate route pool was intended to be 1616

If AXL were to be give as token in, the pool would be found

There are multiple possible solutions to this problem:

  • Run the candidate route search algorithm by starting to search from token in, then starting to search from token out
    • Downside: affects performance
  • Track Astroport PCL pools via config
    • Downside: not an extensible solution. Would not solve the problem for other pool types
  • Prioritiize direct routes
    • Downside: also not always a superior approach
  • Increase max candidate rotues
    • Downside: affects performance
  • Reimplement candidate route algorithm via DATA-174

The last approach is superior and should account for this detail during re-implementation. As a result, for now, we keep this ticket open for tracking purposes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant