From 72d4d478bfc80d335d8a7ed8dda1809eb587651d Mon Sep 17 00:00:00 2001 From: Alexander Goscinski Date: Mon, 1 Jul 2024 22:38:26 +0200 Subject: [PATCH] Drop notebook 7 tests The new version updates have made the notebook 7 tests unfeasible to further maintain. See issues #49 and #50. --- .github/workflows/tests-notebook-7.yml | 38 -------------------------- tox.ini | 32 ---------------------- 2 files changed, 70 deletions(-) delete mode 100644 .github/workflows/tests-notebook-7.yml diff --git a/.github/workflows/tests-notebook-7.yml b/.github/workflows/tests-notebook-7.yml deleted file mode 100644 index 82c88e9..0000000 --- a/.github/workflows/tests-notebook-7.yml +++ /dev/null @@ -1,38 +0,0 @@ -name: Tests - notebook 7 - -on: - push: - branches: [main] - pull_request: - # Check all PR - -jobs: - tests: - runs-on: ${{ matrix.os }} - strategy: - matrix: - include: - - os: ubuntu-22.04 - python-version: "3.11" - - steps: - - uses: actions/checkout@v3 - - name: Install Firefox - uses: browser-actions/setup-firefox@latest - - - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v4 - with: - python-version: ${{ matrix.python-version }} - - run: pip install tox - - - name: run Python tests - run: tox -e tests-notebook-7 - - - name: run Python tests for coverage - run: tox -e coverage - - uses: codecov/codecov-action@v3 - with: - files: coverage.xml - verbose: true - diff --git a/tox.ini b/tox.ini index 08b4c2c..a4f101c 100644 --- a/tox.ini +++ b/tox.ini @@ -11,38 +11,6 @@ envlist = [testenv] -[testenv:tests-notebook-7] -description = - Tests with jupyter notebook version > 7 -setenv = - # this is needed to run selenium on a machine without display to do CI - SELENIUM_FIREFOX_DRIVER_ARGS = {env:SELENIUM_FIREFOX_DRIVER_ARGS:--headless} - JUPYTER_TYPE = notebook - # use the jupyter config in the tox environment - # otherwise the users config is used - JUPYTER_CONFIG_DIR={envdir}/etc/jupyter - JUPYTER_DATA_DIR={envdir}/share/jupyter -deps = - pytest<8.0.0 - pytest-html<4.0.0, - # selenium juypter notebook tests - notebook==7.0.2 - # fixing selenium version to have backwards-compatibility with pytest-selenium - # see https://github.com/robotframework/SeleniumLibrary/issues/1835#issuecomment-1581426365 - selenium==4.9.0 - pytest-selenium - jupytext==1.15.0 - imageio - # we fix matplotlib for consistent image tests - matplotlib==3.7.2 - numpy<2.0.0 - scikit-image - ipympl -commands = - # converts the python files to ipython notebooks - jupytext tests/notebooks/*.py --to ipynb - pytest {posargs:-v} --driver Firefox - [testenv:tests-lab-3] description = Tests with jupyter lab version < 4