Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile on armv7 #52

Closed
1 of 2 tasks
abemedia opened this issue Jul 4, 2021 · 4 comments
Closed
1 of 2 tasks

Cannot compile on armv7 #52

abemedia opened this issue Jul 4, 2021 · 4 comments

Comments

@abemedia
Copy link

abemedia commented Jul 4, 2021

Checklist

  • I have searched the issue list
  • I have tested my example against Shopify Liquid. (This isn't necessary if the actual behavior is a panic, or an error for which IsTemplateError returns false.)

Expected Behavior

I can compile for armv7

Actual Behavior

Throws error: yaccpar:452: constant 4294967295 overflows int

Detailed Description

It appears somewhere there's a constant which is too large for anything but a 64bit environment.

Possible Solution

Would be good to add some build tags to have a different value for other environments.

@osteele
Copy link
Owner

osteele commented Jul 5, 2021

I've just merged @bendoerr's PR#47, which I believe fixes this. I don't currently have a way to verify this (see PR #49), so I'm leaving this bug open until this is confirmed.

@bendoerr
Copy link
Contributor

bendoerr commented Jul 5, 2021

WOW Thanks @osteele! I intended to get to it last week but lots got in the way. I'll have someone give it a test soon.

@abemedia
Copy link
Author

abemedia commented Jul 5, 2021

Will give it a try after work tonight. Thanks!

@abemedia
Copy link
Author

abemedia commented Jul 5, 2021

Just tested it and can confirm it's working on armv7 now. Thanks a lot @osteele and @bendoerr!

@abemedia abemedia closed this as completed Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants