-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to ts-sc-client 0.5.0 #28
base: main
Are you sure you want to change the base?
Conversation
Your free trial has expired. To keep using Ellipsis, sign up at https://app.ellipsis.dev or contact us. |
src/api/requests/scn.ts
Outdated
const res = await translate(question, 'format_scn_json', 'lang_ru'); | ||
const requestScnTree = async (action: number): Promise<IReturnScnTree | AxiosError | null> => { | ||
const res = await translate(action, 'format_scn_json', 'lang_ru'); | ||
console.log(res); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to remove log?
src/components/Scn/Scn.tsx
Outdated
|
||
const onAskQuestion = async (addr: number) => { | ||
const onAskAction = async (addr: number) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actions aren't asked
src/pages/Command/Command.tsx
Outdated
ru: `Не удалось сохранить вопрос ${action} в историю`, | ||
en: `It's failed to save action ${action} in history`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question in russian message
9c8ea29
src/pages/Command/Command.tsx
Outdated
@@ -54,19 +54,23 @@ const Command = () => { | |||
|
|||
if (isAxiosError(cmdRes)) { | |||
setIsLoading(false); | |||
return addError(translate({ ru: 'Не удалось выполнить запрос', en: `It's failed to get request` })); | |||
return addError( | |||
translate({ ru: 'Не удалось выполнить запрос', en: `It's failed to get request` }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translate({ ru: 'Не удалось выполнить запрос', en: `It's failed to get request` }), | |
translate({ ru: 'Не удалось выполнить запрос', en: `It's failed to execute request` }), |
docs/changelog.md
Outdated
@@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
- Changelog | |||
- Docker support | |||
|
|||
### Changed | |||
|
|||
- Migrate to API of the OSTIS Platform 0.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't at least one mention of ostis-ui-lib be updated? and shouldn't this change be mentioned here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why'd you remove changes in changelog?
also what I meant is that package.lock and other places where ostis-ui-lib dependency or ts-sc-client dependency are mentioned should be updated
I removed updates in changelog, because there is no changes from the previous version as there was no previous version. package.json was updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sc-web scg-iframe branch uses old ts-sc-client so I won't be able to run this pr to check if it works?
You can check it using quick start in Metasystem |
Depends from ostis-ai/ostis-ui-lib#61