Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ts-sc-client 0.5.0 #28

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

NikitaZotov
Copy link
Member

@NikitaZotov NikitaZotov commented Feb 4, 2025

@NikitaZotov NikitaZotov self-assigned this Feb 4, 2025
Copy link

ellipsis-dev bot commented Feb 4, 2025

Your free trial has expired. To keep using Ellipsis, sign up at https://app.ellipsis.dev or contact us.

KovalM
KovalM previously approved these changes Feb 4, 2025
MikhailSadovsky
MikhailSadovsky previously approved these changes Feb 4, 2025
const res = await translate(question, 'format_scn_json', 'lang_ru');
const requestScnTree = async (action: number): Promise<IReturnScnTree | AxiosError | null> => {
const res = await translate(action, 'format_scn_json', 'lang_ru');
console.log(res);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to remove log?


const onAskQuestion = async (addr: number) => {
const onAskAction = async (addr: number) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions aren't asked

Comment on lines 39 to 40
ru: `Не удалось сохранить вопрос ${action} в историю`,
en: `It's failed to save action ${action} in history`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question in russian message

@@ -54,19 +54,23 @@ const Command = () => {

if (isAxiosError(cmdRes)) {
setIsLoading(false);
return addError(translate({ ru: 'Не удалось выполнить запрос', en: `It's failed to get request` }));
return addError(
translate({ ru: 'Не удалось выполнить запрос', en: `It's failed to get request` }),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
translate({ ru: 'Не удалось выполнить запрос', en: `It's failed to get request` }),
translate({ ru: 'Не удалось выполнить запрос', en: `It's failed to execute request` }),

@@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Changelog
- Docker support

### Changed

- Migrate to API of the OSTIS Platform 0.10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't at least one mention of ostis-ui-lib be updated? and shouldn't this change be mentioned here?

Copy link
Member

@kilativ-dotcom kilativ-dotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why'd you remove changes in changelog?
also what I meant is that package.lock and other places where ostis-ui-lib dependency or ts-sc-client dependency are mentioned should be updated

@NikitaZotov
Copy link
Member Author

NikitaZotov commented Feb 14, 2025

why'd you remove changes in changelog? also what I meant is that package.lock and other places where ostis-ui-lib dependency or ts-sc-client dependency are mentioned should be updated

I removed updates in changelog, because there is no changes from the previous version as there was no previous version.

package.json was updated

Copy link
Member

@kilativ-dotcom kilativ-dotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sc-web scg-iframe branch uses old ts-sc-client so I won't be able to run this pr to check if it works?

@NikitaZotov NikitaZotov changed the title Migrate to the OSTIS Platform 0.10.0 Migrate to ts-sc-client 0.5.0 Feb 18, 2025
@NikitaZotov
Copy link
Member Author

sc-web scg-iframe branch uses old ts-sc-client so I won't be able to run this pr to check if it works?

You can check it using quick start in Metasystem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants