-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][docs] Change conan remote url #475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 7ada5da in 49 seconds
More details
- Looked at
54
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
8
drafted comments based on config settings.
1. .github/workflows/release.yml:84
- Draft comment:
Updated Conan remote URL looks consistent. Confirm remote URL change is intended. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is asking the PR author to confirm their intention, which violates the rule against asking for confirmation of intention. It does not provide a specific suggestion or point out a specific issue with the code.
2. docs/build/build_system.md:141
- Draft comment:
Conan remote URL updated in docs. Verify that all documentation references are consistent. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is asking the PR author to verify consistency in documentation, which falls under the rule of not asking the author to double-check things. It doesn't provide a specific suggestion or point out a specific issue, so it should be removed.
3. docs/changelog.md:16
- Draft comment:
Changelog updated with new Conan remote URL. Ensure consistency with code and docs. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is asking the PR author to ensure consistency between the changelog, code, and documentation. It doesn't provide a specific suggestion or point out a specific issue, which violates the rule against asking the author to ensure something is correct without being specific. Therefore, this comment should not be approved.
4. docs/quick_start.md:44
- Draft comment:
Remote URL updated to ostis-ai-library. Documentation aligns with other changes. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is purely informative, stating that the remote URL was updated and documentation aligns with other changes. It doesn't provide any actionable feedback or suggestions for improvement.
5. .github/workflows/release.yml:84
- Draft comment:
Conan remote URL updated correctly, but consider removing the trailing slash here to match other references. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
6. docs/build/build_system.md:141
- Draft comment:
Conan remote URL updated consistently. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
7. docs/changelog.md:16
- Draft comment:
Changelog entry reflects the new Conan remote URL correctly. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
8. docs/quick_start.md:44
- Draft comment:
Quick Start instructions now use the updated Conan remote URL. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
Workflow ID: wflow_HSxKNnZGlsNjkdgv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
@ellipsis, please, give me a code review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to ec578ad in 50 seconds
More details
- Looked at
72
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
10
drafted comments based on config settings.
1. .github/workflows/release.yml:84
- Draft comment:
Updated Conan remote URL looks correct; ensure that remote login steps match the new URL. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
2. .github/workflows/test_native.yml:12
- Draft comment:
Matrix variable update to use 'build_type.name' is clearer and consistent. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
3. docs/build/build_system.md:141
- Draft comment:
Updated remote URL to the new '-library' endpoint; ensure documentation matches release workflow. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
4. docs/changelog.md:16
- Draft comment:
Changelog updated with new Conan remote URL, which is accurate. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
5. docs/quick_start.md:44
- Draft comment:
Conan remote URL in quick start has been updated to the new URL; seems consistent with docs. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
6. .github/workflows/release.yml:84
- Draft comment:
Updated conan remote URL is correct. Consider aligning trailing slash usage with docs for consistency. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
7. .github/workflows/test_native.yml:12
- Draft comment:
Using matrix.build_type.name is appropriate to access the preset name. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
8. docs/build/build_system.md:141
- Draft comment:
Conan remote URL updated correctly in the documentation. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
9. docs/changelog.md:16
- Draft comment:
Changelog now documents the updated conan remote URL. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
10. docs/quick_start.md:44
- Draft comment:
Quick start now references the updated conan remote URL, maintaining consistency across docs. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
Workflow ID: wflow_ZvxGZXRJCYVbQSO7
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
==========================================
- Coverage 95.77% 95.75% -0.02%
==========================================
Files 237 237
Lines 27369 27369
Branches 1877 1877
==========================================
- Hits 26212 26208 -4
- Misses 1157 1161 +4 |
ec578ad
to
2779520
Compare
Important
Change Conan remote URL and update matrix variable in GitHub workflow.
https://conan.ostis.net/artifactory/api/conan/ostis-ai-sc-machine/
tohttps://conan.ostis.net/artifactory/api/conan/ostis-ai-library
inrelease.yml
,build_system.md
, andquick_start.md
.matrix.build_type
tomatrix.build_type.name
intest_native.yml
.This description was created by
for ec578ad. It will automatically update as commits are pushed.