Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix grammar in CONTRIBUTING.md #43

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

NikitaZotov
Copy link
Member

@NikitaZotov NikitaZotov commented Feb 20, 2025


Important

Fixes grammar in CONTRIBUTING.md under the Pull Request Review section for clarity.

  • Documentation:
    • Fixes grammar in CONTRIBUTING.md under the Pull Request Review section.
    • Changes include correcting verb forms and punctuation for clarity.

This description was created by Ellipsis for 6455023. It will automatically update as commits are pushed.

@NikitaZotov NikitaZotov self-assigned this Feb 20, 2025
@NikitaZotov NikitaZotov added this to the 0.1.1 milestone Feb 20, 2025
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6455023 in 43 seconds

More details
  • Looked at 18 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 7 drafted comments based on config settings.
1. docs/CONTRIBUTING.md:110
  • Draft comment:
    Good grammar corrections in the Pull Request Review section. Changes are clear and improve readability.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. docs/CONTRIBUTING.md:110
  • Draft comment:
    Good improvement in the grammar for the review section; the subject–verb agreements and phrasing are now consistent.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
3. docs/CONTRIBUTING.md:1
  • Draft comment:
    Line 1: "This page describes rules to contribute changes and features by Pull Requests creating." is awkwardly phrased. Consider rephrasing to something like "This page describes the rules for contributing changes and features via Pull Requests."
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. docs/CONTRIBUTING.md:64
  • Draft comment:
    Line 64: "Each commit in Pull Request should be an atomic." is grammatically incorrect. Consider using "Each commit in a Pull Request should be atomic." or "Each commit should be an atomic commit."
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. docs/CONTRIBUTING.md:76
  • Draft comment:
    Line 76: "Each commit should have not much differences excluding cases, with:" is awkward. Consider revising to "Each commit should not have many differences, except in cases such as:".
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. docs/CONTRIBUTING.md:81
  • Draft comment:
    Line 81: "Do atomic commits for each changes." should be corrected to "Do atomic commits for each change."
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
7. docs/CONTRIBUTING.md:94
  • Draft comment:
    Line 94: "Each Pull Request with many changes, that not possible to review (excluding codestyle, rename changes), will be rejected." could be improved. Consider revising to "Any Pull Request with many changes that are not possible to review (excluding codestyle or rename changes) will be rejected."
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_NhnRXmkFnLRUYPbh


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NikitaZotov NikitaZotov merged commit f5408a8 into ostis-ai:main Feb 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant