Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avakas will attempt to commit changes even when the version is the same as the existent version #66

Open
tyler-jachetta opened this issue Jan 11, 2021 · 1 comment
Labels

Comments

@tyler-jachetta
Copy link
Collaborator

The fact that the auto bump is setting the version to the same version in the case I found is captured in #63 . I think that attempting to change the version to what it currently is seems like a bad thing. In our circleCI work, this led to a no changes commit happening saying that it was bumping the version (in that it made a commit to commit the version file, but since no changes...).

I'm not sure how we want to handle it exactly, but should we do something like raise some sort of AvakasError if we try to set the version to the get result?

my 2c is that testing this sort of functionality lies inside of unit tests. Gonna whip up a quick PR with some unit tests to test this (unless I should not persue)

@otakup0pe
Copy link
Owner

This does feel like a gap in testing and ux. Even ignoring the underling issue with prerelease there is always the manual set action.

@otakup0pe otakup0pe added the bug label Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants