You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fact that the auto bump is setting the version to the same version in the case I found is captured in #63 . I think that attempting to change the version to what it currently is seems like a bad thing. In our circleCI work, this led to a no changes commit happening saying that it was bumping the version (in that it made a commit to commit the version file, but since no changes...).
I'm not sure how we want to handle it exactly, but should we do something like raise some sort of AvakasError if we try to set the version to the get result?
my 2c is that testing this sort of functionality lies inside of unit tests. Gonna whip up a quick PR with some unit tests to test this (unless I should not persue)
The text was updated successfully, but these errors were encountered:
The fact that the auto bump is setting the version to the same version in the case I found is captured in #63 . I think that attempting to change the version to what it currently is seems like a bad thing. In our circleCI work, this led to a no changes commit happening saying that it was bumping the version (in that it made a commit to commit the version file, but since no changes...).
I'm not sure how we want to handle it exactly, but should we do something like raise some sort of
AvakasError
if we try to set the version to the get result?my 2c is that testing this sort of functionality lies inside of unit tests. Gonna whip up a quick PR with some unit tests to test this (unless I should not persue)
The text was updated successfully, but these errors were encountered: