You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
using strip() in this case has some issues (using v as sample prefix):
if the version string ends with v (e.g. '1.2.3-dev'), trailing v will be stripped
the first argument to strip is treated as a collection (even though a non-string will raise a TypeError), and all instances of any character in the prefix will be stripped from both ends. Thus:
avakas/avakas/avakas.py
Line 66 in f554dea
using
strip()
in this case has some issues (usingv
as sample prefix):v
(e.g.'1.2.3-dev'
), trailingv
will be strippedstrip
is treated as a collection (even though a non-string will raise aTypeError
), and all instances of any character in the prefix will be stripped from both ends. Thus:Don't have tests exercising this done yet, just saw this issue and logging it for now. No known cases of error in the wild
The text was updated successfully, but these errors were encountered: