Define [[, ]], [], ][, [", ]" also for visual modes

[kiryph]

In an xml file :map [[ will tell you that [[ is remapped by this plugin to

n [[ *@m':call <SNR>148_findOpenTag('bW')<CR>

I would like to adjust my visual selection with the motions defined by this plugin.

However, a :xmap [[ will say No Mapping Found.

I tried a naive approache to add them

~/.vim/pack/minpac/start/xml.vim master*
❯ g diff
diff --git a/ftplugin/xml.vim b/ftplugin/xml.vim
index fc67f1b..0990097 100644
--- a/ftplugin/xml.vim
+++ b/ftplugin/xml.vim
@@ -1479,10 +1479,16 @@ call s:unmapKeys()
   call <SID>mapKey('n', ']]', "m':call <SID>findOpenTag('W')<CR>")
   call <SID>mapKey('n', '[]', "m':call <SID>findCloseTag('bW')<CR>")
   call <SID>mapKey('n', '][', "m':call <SID>findCloseTag('W')<CR>")
+  call <SID>mapKey('x', '[[', "m':call <SID>findOpenTag('bW')<CR>")
+  call <SID>mapKey('x', ']]', "m':call <SID>findOpenTag('W')<CR>")
+  call <SID>mapKey('x', '[]', "m':call <SID>findCloseTag('bW')<CR>")
+  call <SID>mapKey('x', '][', "m':call <SID>findCloseTag('W')<CR>")

   " Move around comments                                                  {{{2
   call <SID>mapKey('n', ']"', substitute(':call search("^\(\s*<!--.*\n\)\@<!\(\s*-->\)", "W")<CR>', '"', "'", 'g'))
   call <SID>mapKey('n', '["', substitute(':call search("\%(^\s*<!--.*\n\)\%(^\s*-->\)\@!", "bW")<CR>', '"', "'", 'g'))
+  call <SID>mapKey('x', ']"', substitute(':call search("^\(\s*<!--.*\n\)\@<!\(\s*-->\)", "W")<CR>', '"', "'", 'g'))
+  call <SID>mapKey('x', '["', substitute(':call search("\%(^\s*<!--.*\n\)\%(^\s*-->\)\@!", "bW")<CR>', '"', "'", 'g'))

   " insert mode shortcuts                                                 {{{2
   call <SID>mapKey('i', b:suffix, ' ><Esc>db:call <SID>makeElement()<Cr>')

But this does not work.

Would you be interest in adding them?