From ac87bc4c9d86233b76ad6e93e2678342aecce484 Mon Sep 17 00:00:00 2001 From: Dan Oved Date: Tue, 28 Nov 2023 14:54:06 -0800 Subject: [PATCH] lint fix --- .changeset/pink-turtles-watch.md | 2 +- .../src/premint/premint-api-client.ts | 2 +- .../src/premint/premint-client.test.ts | 37 ++++++++++++------- .../src/premint/premint-client.ts | 14 +++++-- 4 files changed, 35 insertions(+), 20 deletions(-) diff --git a/.changeset/pink-turtles-watch.md b/.changeset/pink-turtles-watch.md index 279835d3b..65e056711 100644 --- a/.changeset/pink-turtles-watch.md +++ b/.changeset/pink-turtles-watch.md @@ -2,4 +2,4 @@ "@zoralabs/protocol-sdk": patch --- -premintClient has http methods overridable via dependency injection, and now takes publicClient and http overrides in `createPremintClient` function. it no longer takes `publicClient` as an argument in functions, and rather uses them from the constructor +premintClient can have http methods overridable via DI, and now takes publicClient and http overrides in `createPremintClient` function. it no longer takes `publicClient` as an argument in functions, and rather uses them from the constructor. `executePremint` has been renamed ot `makeMintParameters` diff --git a/packages/protocol-sdk/src/premint/premint-api-client.ts b/packages/protocol-sdk/src/premint/premint-api-client.ts index cb78cc42d..5b7c45b41 100644 --- a/packages/protocol-sdk/src/premint/premint-api-client.ts +++ b/packages/protocol-sdk/src/premint/premint-api-client.ts @@ -27,7 +27,7 @@ type PremintSignatureGetPathParameters = export type PremintSignatureGetResponse = SignaturePremintGetType["responses"][200]["content"]["application/json"]; -export type PremintCollection = PremintSignatureGetResponse['collection']; +export type PremintCollection = PremintSignatureGetResponse["collection"]; export type BackendChainNames = components["schemas"]["ChainName"]; diff --git a/packages/protocol-sdk/src/premint/premint-client.test.ts b/packages/protocol-sdk/src/premint/premint-client.test.ts index 7b6c07216..7a656df6e 100644 --- a/packages/protocol-sdk/src/premint/premint-client.test.ts +++ b/packages/protocol-sdk/src/premint/premint-client.test.ts @@ -8,7 +8,10 @@ describe("ZoraCreator1155Premint", () => { "can sign on the forked premint contract", async ({ viemClients: { walletClient, publicClient } }) => { const [deployerAccount] = await walletClient.getAddresses(); - const premintClient = createPremintClient({ chain: foundry, publicClient }); + const premintClient = createPremintClient({ + chain: foundry, + publicClient, + }); premintClient.apiClient.getNextUID = vi .fn() @@ -68,7 +71,10 @@ describe("ZoraCreator1155Premint", () => { anvilTest( "can validate premint on network", async ({ viemClients: { publicClient } }) => { - const premintClient = createPremintClient({ chain: foundry, publicClient }); + const premintClient = createPremintClient({ + chain: foundry, + publicClient, + }); const premintData = { collection: { @@ -145,19 +151,22 @@ describe("ZoraCreator1155Premint", () => { }); premintClient.apiClient.postSignature = vi.fn(); - const simulateContractParameters = await premintClient.makeMintParameters({ - account: deployerAccount!, - data: await premintClient.getPremintData({ - address: "0xf8dA7f53c283d898818af7FB9d98103F559bDac2", - uid: 3, - }), - mintArguments: { - quantityToMint: 1, - mintComment: "", + const simulateContractParameters = await premintClient.makeMintParameters( + { + account: deployerAccount!, + data: await premintClient.getPremintData({ + address: "0xf8dA7f53c283d898818af7FB9d98103F559bDac2", + uid: 3, + }), + mintArguments: { + quantityToMint: 1, + mintComment: "", + }, }, - }); - const { request: simulateRequest } = - await publicClient.simulateContract(simulateContractParameters); + ); + const { request: simulateRequest } = await publicClient.simulateContract( + simulateContractParameters, + ); const hash = await walletClient.writeContract(simulateRequest); const receipt = await publicClient.waitForTransactionReceipt({ hash }); const { premintedLog, urls } = diff --git a/packages/protocol-sdk/src/premint/premint-client.ts b/packages/protocol-sdk/src/premint/premint-client.ts index 84a39cf23..33abcbb35 100644 --- a/packages/protocol-sdk/src/premint/premint-client.ts +++ b/packages/protocol-sdk/src/premint/premint-client.ts @@ -149,11 +149,15 @@ class PremintClient { readonly publicClient: PublicClient; readonly chain: Chain; - constructor(chain: Chain, publicClient?: PublicClient, httpClient?: IHttpClient) { + constructor( + chain: Chain, + publicClient?: PublicClient, + httpClient?: IHttpClient, + ) { this.chain = chain; this.apiClient = new PremintAPIClient(chain.id, httpClient); this.publicClient = - publicClient || createPublicClient({ chain, transport: http() }); + publicClient || createPublicClient({ chain, transport: http() }); } /** @@ -590,9 +594,11 @@ class PremintClient { export function createPremintClient({ chain, httpClient, - publicClient + publicClient, }: { - chain: Chain, publicClient?: PublicClient, httpClient?: IHttpClient + chain: Chain; + publicClient?: PublicClient; + httpClient?: IHttpClient; }) { return new PremintClient(chain, publicClient, httpClient); }