Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable requests_cache within load_annotations function and disable it afterwards #5

Open
newgene opened this issue May 10, 2020 · 0 comments
Open

enable requests_cache within load_annotations function and disable it afterwards #5

newgene opened this issue May 10, 2020 · 0 comments
Assignees
@marcodarko

Comments

@newgene
Copy link
Collaborator

newgene commented May 10, 2020

Avoid to set requests_cache globally, which can interfere with requests module used elsewhere

Consider move these two lines into load_annotations function and disable the cache when parsing is done:
https://github.com/marcodarko/litcovid/blob/d217e29e3af4218a9f19812cb51fd9f411d22e0c/parser.py#L20

This can be done using this context manager:
https://requests-cache.readthedocs.io/en/latest/api.html#requests_cache.core.enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcodarko marcodarko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@newgene @marcodarko