Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False link detection #245

Closed
invisal opened this issue Jan 16, 2025 · 2 comments
Closed

False link detection #245

invisal opened this issue Jan 16, 2025 · 2 comments

Comments

@invisal
Copy link
Collaborator

invisal commented Jan 16, 2025

Image

We occasionally misinterpret anything with ":" as a link, which can be frustrating. Could you assist with this issue?

Related code here:
https://github.com/outerbase/studio/blob/notebook/src/components/gui/table-cell/generic-cell.tsx#L227
@thormengkheang
Copy link
Contributor

thormengkheang commented Jan 16, 2025 •
edited
Loading

I can help with this issue. I will write a link regex and test with different cases. Also there is a redundant isLinkString function in the file https://github.com/outerbase/studio/blob/notebook/src/components/lib/validation.ts#L72

@invisal
Copy link
Collaborator Author

invisal commented Jan 24, 2025

@thormengkheang this issue has been covered by @sokphaladam at the moment.

@invisal invisal closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@invisal @thormengkheang