Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manager-components]: Use React Node instead of string for description props on BaseLayout component #15268

Open
1 task done
kqesar opened this issue Feb 3, 2025 · 1 comment
Labels
enhancement New feature or request manager-components

Comments

@kqesar
Copy link
Contributor

kqesar commented Feb 3, 2025

Have you already checked if a similar item is present on manager-components?

  • Yes, I have already checked the existing components/hooks/utils.

What do you expect from this request?

Component

Description

Hello,

We need to have the possibility to set a ReactNode / JSX instead of string for the props description for BaseLayout component because in Cold Archive the description have a Link

Thank you

Image

Where do you expect to use this?

Cold Archive

Do you have mock-up?

No

When do you expect this to be delivered?

17-02-2025

Additional Information

No response

@kqesar kqesar added enhancement New feature or request manager-components labels Feb 3, 2025
@anooparveti
Copy link
Contributor

We want to avoid converting string to ReactNode as it opens the doors for adding more customisation to the layout with custom CSS. So, we 're discussing the alternatives with @feoche and design team.

For now, maybe you can proceed with the alternative to type cast react element to string. Refer: https://github.com/ovh/manager/blob/master/packages/manager/apps/zimbra/src/components/layout-helpers/Dashboard/Dashboard.tsx#L170-L194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request manager-components
Projects
None yet
Development

No branches or pull requests

2 participants