Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manager-components]: <ActionBanner> #15742

Closed
1 task done
seven-amid opened this issue Feb 28, 2025 · 0 comments · Fixed by #15759
Closed
1 task done

[manager-components]: <ActionBanner> #15742

seven-amid opened this issue Feb 28, 2025 · 0 comments · Fixed by #15759

Comments

@seven-amid
Copy link
Contributor

seven-amid commented Feb 28, 2025

Have you already checked if a similar item is present on manager-components?

  • Yes, I have already checked the existing components/hooks/utils.

What do you expect from this request?

Component

Description

We have some style issues with the ActionBanner,

1 - The color of the text should be adapted to the color of the OdsMessage ( for example in this use case the message color is a warning, while the text inside is in primary ! (should be in warning color too) )
2 - The message box should have a 100% width.
3 - The icon is not vertically centered
4 - The button/link must be below the text (which solves the point N°3)

Image

UPDATE

As seen with the ODS and Design teams, the icon must not be centered, but the action button/link must be bellow the text.

Where do you expect to use this?

in all migrated projects using ods18 in PCI

Do you have mock-up?

No response

When do you expect this to be delivered?

ASAP

Additional Information

No response

seven-amid added a commit that referenced this issue Mar 3, 2025
@seven-amid seven-amid linked a pull request Mar 3, 2025 that will close this issue
seven-amid added a commit that referenced this issue Mar 6, 2025
seven-amid added a commit that referenced this issue Mar 7, 2025
anooparveti pushed a commit that referenced this issue Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants