Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exe_type to make it architecture neutral #114

Open
prabhu opened this issue Jul 29, 2024 · 0 comments
Open

Improve exe_type to make it architecture neutral #114

prabhu opened this issue Jul 29, 2024 · 0 comments

Comments

@prabhu
Copy link
Member

prabhu commented Jul 29, 2024

We currently construct exe_type attribute based on machine and file type.

return f'{metadata.get("machine_type")}-{metadata.get("file_type")}'.lower()

In annotations, we have hard coded x86_64 in multiple places. Example: x86_64-exec. This means architecture such as arm and aarch64 is not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant