-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SolrCommandRunner should skip models that are unsatisfiable #234
Comments
Okay, I'm able to proceed, but I'm now able to see the practical logic behind it as currently all models I've tried have failed so far like:
tagging @cmungall |
It should be safe to load incoherent consistent models. We should never use the reasoner with inconsistent models |
It looks like the only unsatisfiable GO class is virion membrane. This is pretty weird and we should investigate, I assume it's old+new axioms superimposed. All the rest are EMAPAs, this should only affect MGI annotations that reference these @ukemi - this is another challenge of allowing EMAPA plus Uberon, it's another thing that can become inconsistent. Uberon has a lot of strict axioms that may be vioated by the EMAPA subclasses. In future I'd like to use uberon for all metazoa in Noctua, and map to ssAOs after the fact |
|
Testing the loader, we now fail with:
This is understandable as (IIRC) it is part of a set of mock-up models--I doubt anything sensible would be loaded even it was satisfiable. I think the best course of action would be to continue on with other models if any single model unsatisfiable. I would like to have something in there soon for demo purposes and this would be the fastest way forward.
Hopefully I'll be able to supply a PR soon...
The text was updated successfully, but these errors were encountered: