Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity. link token in activity confused users #10295

Open
ScharfViktor opened this issue Oct 11, 2024 · 2 comments
Open

Activity. link token in activity confused users #10295

ScharfViktor opened this issue Oct 11, 2024 · 2 comments
Labels

Comments

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Oct 11, 2024

I found a few problems while increasing the coverage for activity.feature

ocis 6.5.0
web. 10.3.0

1. ## superfluous activities fixed via owncloud/web#11770
Steps:
- admin creates space link (view role by default)
- admin changes link role to edit role
- admin sees activity

Actual:
Screenshot 2024-10-11 at 14 42 09

reason: we send @libre.graph.displayName and type in the PATCH body request if we only update displayName or type(permission)

1.1 ## superfluous activities - #10293
~~Steps: ~~
- admin creates space link with edit role
- public updates file file.txt (public opens file in text editor- put content-> save->close editor)
- admin sees activity

~~Actual: ~~
image

Expected: file.txt was downloaded via public link fguCwoKHERsDYim is superfluous.

  1. link token in activity confused users. I first noticed this when I updated the link password and wondered if I was seeing the password in activity (it was link token)

Steps:

  • admin creates 2 space links (Unnamed link and new link)
  • admin changes role of the new link
  • admin sees activity

Actual: Admin updated permission for a link fhLLZLQKeooTvry on s2
I know that fhLLZLQKeooTvry is link token
But for many users, this may not be obvious
image

Expected: Admin updated permission for a link new on s2
If we have both Unnamed links -> here is question but maybe better to provide Admin updated permission for a link Unnamed on s2. not sure here

@AlexAndBear
Copy link
Contributor

Issue 1 is on us. Issue 2 is more likely a backend issue

@AlexAndBear
Copy link
Contributor

Transferred to ocis repo, as #1 has been fixed via owncloud/web#11770

@ScharfViktor ScharfViktor changed the title Activity. superfluous activity when changing space link Activity. link token in activity confused users Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Qualification
Development

No branches or pull requests

2 participants