Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] <Unexpected 3rd party reactions on msgs in P2P conversation> #3086

Open
3 tasks done
eugenesan opened this issue Apr 27, 2024 · 6 comments
Open
3 tasks done

[BUG] <Unexpected 3rd party reactions on msgs in P2P conversation> #3086

eugenesan opened this issue Apr 27, 2024 · 6 comments
Labels
bug Something isn't working Jira This ticket is being tracked in Jira

Comments

@eugenesan
Copy link

Code of conduct

Self-training on how to write a bug report

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

On Android and Desktop, since a few days ago, I am seeing unexpected 3rd party reactions to msgs sent to me inside P2P conversation.
The other party of the conversion do not see the reactions.

Some of the reactions bleed to other clients.

Another person complained about the same issue on Session group chat.
Interestingly, at leas one of the unexpected reactions were from that person.
I have no contact with that person.

My current theory is that reactions somehow bleed between P2P and Group conversions.

Cross reporting Android Client as they are both affected: oxen-io/session-android#1470

Update: Some of the reactions disappear if I am trying interact with them as if they were mine and the client did "-1".

Expected Behavior

No 3rd party anything in P2P conversions

Steps To Reproduce

There is nothing to do.
Some msgs from other party in P2P conversion just shown with 3rd party reactions.

Desktop Version

1.12.2

Anything else?

No response

@KeeJef
Copy link
Collaborator

KeeJef commented May 2, 2024

I did see reports of this from other user, haven't been able to find a case to reproduce yet though

@pottsandpans pottsandpans added the Jira This ticket is being tracked in Jira label May 15, 2024
@pottsandpans
Copy link
Collaborator

We are tracking this internally via Jira - SES-1807

@jnorthrup
Copy link

#3103 [author sweeping under the rug] appears to be bleeding back to google personalization

@eugenesan
Copy link
Author

@jnorthrup
I don't think this issue is related to the issue you referenced, at least I hope so.

This issue is about session client/network leaking messages/reactions between chats open by the same client/identity.

That said, this issue is critical and I no longer can recommend using session for anything except public chats.
Especially after developers didn't address it in any meaningful form for 3 weeks...

@KeeJef
Copy link
Collaborator

KeeJef commented May 21, 2024

We need to investigate this issue further, but based on our observations, it appears to be a UI-specific problem that occurs rarely. Essentially, reactions received from communities or closed groups are being incorrectly assigned to the wrong messages at the UI level. This can result in reactions from a community appearing on a 1-1 message or a closed group message. However, the reaction is not actually being sent to your message, and doesn't appear for other users, its a UI assignment issue.

@jnorthrup
Copy link

| That said, this issue is critical and I no longer can recommend using session for anything except public chats.

responses like "stop using that OS" in response to a pretty clear leak of messages does underscore your quote as well, noone should ever want a secure messenger to write a "note to self" across platforms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Jira This ticket is being tracked in Jira
Projects
None yet
Development

No branches or pull requests

4 participants