Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow cargo-driven Rust tool updates during build #53

Open
wesolows opened this issue Feb 27, 2023 · 0 comments
Open

disallow cargo-driven Rust tool updates during build #53

wesolows opened this issue Feb 27, 2023 · 0 comments
Milestone

Comments

@wesolows
Copy link
Contributor

Using the rust-toolchain.toml feature in repos containing Rust code is a good way to make sure the right/expected toolchain gets used when building it (unless you're a library in which case haha fuck you!!!). But it also induces cargo to invoke, in some manner, rustup if you don't have that toolchain installed, which modifies the build environment. For anything we're going to ship to a customer, we definitely don't want rustup on the machine at all, and we certainly don't want the user doing the build to be able to invoke it. But we do -- I would expect -- want this toolchain version checking for repos that request it. This leads to the conclusion that we probably want to make sure we enumerate the set of toolchains that are expected to be used ourselves, and cut rustup out of the picture entirely. If we don't have the right toolchains, we should fail.

@wesolows wesolows added this to the MVP milestone Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant