We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We have a lot more inventory collected since #4753 and all of it is collected serially. We should make it all concurrent.
The text was updated successfully, but these errors were encountered:
If nobody else is planning on working on this, I'd be happy to take a crack at it, I could use a little break from RFD 520. :)
Sorry, something went wrong.
Porting over @andrewjstone's comment on a PR:
There is actually a comment regarding keeping things serial: omicron/nexus/inventory/src/collector.rs Lines 58 to 63 in 809c454 // We're about to do a bunch of asynchronous operations. With a // combination of async, futures, and some cleverness, we could do much // of this in parallel. But this code path is not remotely // latency-sensitive. And there's real risk of overloading our // downstream services. So we just do one step at a time. This also // keeps the code simpler. I think instead we should probably do it in parallel and limit the concurrency with buffer_unordered or something.
There is actually a comment regarding keeping things serial:
omicron/nexus/inventory/src/collector.rs
Lines 58 to 63 in 809c454
I think instead we should probably do it in parallel and limit the concurrency with buffer_unordered or something.
This comment seems like it still applies even though we're collecting more stuff, I think?
No branches or pull requests
We have a lot more inventory collected since #4753 and all of it is collected serially. We should make it all concurrent.
The text was updated successfully, but these errors were encountered: