Skip to content

Commit

Permalink
Re pace-neutrons/Herbert#356 more descriptions according to review.
Browse files Browse the repository at this point in the history
  • Loading branch information
abuts committed Oct 26, 2021
1 parent fd24236 commit 8f3f48a
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 1 deletion.
5 changes: 5 additions & 0 deletions _test/test_instrument_classes/private/check_matfile_IO.m
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@
% varargin -- variables to save/load to/from file. The main part of
% each filename consists of the name of these variables,
% identified using Matlab function "inputname".
% Outputs:
% ok -- true if test passing and false otherwise.
% mess -- the message better identifying the reason for failure.
% Empty if ok==true
%
% NOTE:
% for "inputname" function work correctly, one needs to specify all
% inputs as variables, e.g. calling workspace needs to have
Expand Down
8 changes: 8 additions & 0 deletions herbert_core/utilities/classes/@serializable/serializable.m
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@
% method and adds more fields, responsible for identifying class,
% and array information if array of objects is serialized.
%
% Adds the field "version" containing result of getVersion
% function to the structure, obtained from to_bare_struct
% function.
% If converting array of objects, one can not add single value
% to the array, so function returns the structure with two fields:
% "version" and "array_dat", where array_dat contains the structure
% array, produced by "to_bare_struct" function.
%
% Input:
% obj -- class or array of classes object.
% Returns:
Expand Down
2 changes: 1 addition & 1 deletion herbert_core/utilities/maths/equal_to_tol.m
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ function equal_to_tol_private(a,b,opt,name_a,name_b)
end

% Check fieldnames are identical
fieldsA=fieldnames(struct(a)); % gets hidden properties too
fieldsA=fieldnames(struct(a)); % gets hidden properties too
fieldsB=fieldnames(struct(b));
if ~(numel(fieldsA)==numel(fieldsB))
isBinA = ismember(fieldsA,fieldsB);
Expand Down

0 comments on commit 8f3f48a

Please sign in to comment.