-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[swift] Naming problem #400
Comments
More examples:
This repo must get 3 separate purls based on the Package.swift entries. Instead the spec forces a single purl. https://github.com/elmetal/multi-module-testing-swift/blob/fe9d96e7a04ed390101e7b92cebc26cfe15f1141/Package.swift#L7 |
How would you find the code if the name wasn't the name of the repository? Monorepos sounds like a job for subpaths. |
Purl spec need not worry about linking the purl string to a source repo or distribution url. We have SBOM specifications, like externalReferences in CycloneDX for that purpose. Use of subpath is not correct, since the purl must be based on name and version and must not worry about where the package source code was present in the VCS. For example, in java pom.xml or build.gradle files could be anywhere in the vcs, but the generated purl doesn't change based on the vcs structure. |
If there's no link between the PURL and the source repo or distribution URL, what is the point of the PURL? What package does it represent? There's no way to know whether your "Lottie" and my "Lottie" are the same. Java does not use VCS URLs. Packages are published to a registry, and the pom.xml or build.gradle files are always at a well known location which can be trivially determined based on the PURL. |
As per the spec, repository name must be used as the name.
Take
lottie-ios
. As per its Package.swift, the package name isLottie
.The spec is forcing us to use an incorrect name. It's breaking repositories that are monorepos and multi-modules, hosting multiple swift packages :(
The text was updated successfully, but these errors were encountered: