From 4f1fdcb4e68c54ed4b69fdd8a59d6813d2e4c652 Mon Sep 17 00:00:00 2001 From: Laura Barcziova Date: Wed, 27 Nov 2024 15:52:13 +0100 Subject: [PATCH] Show error messages for Koji builds and Bodhi updates Related to packit/packit-service#2426 --- frontend/src/apiDefinitions.ts | 2 ++ frontend/src/components/bodhi/BodhiUpdate.tsx | 14 ++++++++++++++ frontend/src/components/koji/KojiBuild.tsx | 14 ++++++++++++++ 3 files changed, 30 insertions(+) diff --git a/frontend/src/apiDefinitions.ts b/frontend/src/apiDefinitions.ts index 2d503efb..b6d45ae0 100644 --- a/frontend/src/apiDefinitions.ts +++ b/frontend/src/apiDefinitions.ts @@ -179,6 +179,7 @@ export interface KojiBuild { task_id: string; web_url: string; build_submission_stdout: string | null; + error_message: string | null; } // /api/koji-tag-requests @@ -307,6 +308,7 @@ export interface BodhiUpdate { submitted_time: number; update_creation_time: number | null; web_url: string | null; + error_message: string | null; } // /api/testing-farm/results diff --git a/frontend/src/components/bodhi/BodhiUpdate.tsx b/frontend/src/components/bodhi/BodhiUpdate.tsx index 1e5d0947..f501e2cd 100644 --- a/frontend/src/components/bodhi/BodhiUpdate.tsx +++ b/frontend/src/components/bodhi/BodhiUpdate.tsx @@ -4,6 +4,8 @@ import { Card, CardBody, + CodeBlock, + CodeBlockCode, Content, DescriptionList, DescriptionListDescription, @@ -97,6 +99,18 @@ export const BodhiUpdate = () => { {" "} {data.koji_nvrs} + {data.error_message ? ( + <> + Error message + + + {data.error_message} + + + + ) : ( + <> + )} diff --git a/frontend/src/components/koji/KojiBuild.tsx b/frontend/src/components/koji/KojiBuild.tsx index 48342f04..57c5c3aa 100644 --- a/frontend/src/components/koji/KojiBuild.tsx +++ b/frontend/src/components/koji/KojiBuild.tsx @@ -4,6 +4,8 @@ import { Card, CardBody, + CodeBlock, + CodeBlockCode, Content, DescriptionList, DescriptionListDescription, @@ -158,6 +160,18 @@ export const KojiBuild = () => { not provided )} + {data.error_message ? ( + <> + Error message + + + {data.error_message} + + + + ) : ( + <> + )}