fix: rack 2.x dont load Rack::Handler::WEBrick class to avoid warnings

use webbrick.rb custom handler in cli.rb
pact-foundation · Jun 17, 2024 · c5e2311 · c5e2311
1 parent c4aacf2
commit c5e2311
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/lib/pact/mock_service/cli.rb b/lib/pact/mock_service/cli.rb
@@ -171,11 +171,7 @@ def version
 
         def require_common_dependencies
           require 'webrick/https'
-          begin
-            require 'rack/handler/webrick'
-          rescue LoadError
-            require 'rackup/handler/webrick'
-          end
+          require 'rack/handler/webbrick'
           require 'fileutils'
           require 'pact/mock_service/server/wait_for_server_up'
           require 'pact/mock_service/cli/pidfile'

diff --git a/lib/pact/stub_service/cli.rb b/lib/pact/stub_service/cli.rb
@@ -1,10 +1,6 @@
 require 'pact/mock_service/cli/custom_thor'
 require 'webrick/https'
-begin
-  require 'rack/handler/webrick'
-rescue LoadError
-  require 'rackup/handler/webrick'
-end
+require 'rack/handler/webbrick'
 require 'fileutils'
 require 'pact/mock_service/server/wait_for_server_up'
 require 'pact/mock_service/cli/pidfile'

diff --git a/lib/rack/handler/webbrick.rb b/lib/rack/handler/webbrick.rb
@@ -2,7 +2,6 @@ module Rack
   module Handler
       begin
         require 'rack/handler/webrick'
-        WEBrick = Class.new(Rack::Handler::WEBrick)
       rescue LoadError
         require 'rackup/handler/webrick'
         WEBrick = Class.new(Rackup::Handler::WEBrick)