Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation instructions have the wrong line numbers #46

Open
amuck-gorilla opened this issue Jul 3, 2024 · 2 comments
Open

Installation instructions have the wrong line numbers #46

amuck-gorilla opened this issue Jul 3, 2024 · 2 comments

Comments

@amuck-gorilla
Copy link

In the README's instructions for installation, the line numbers in the title of the linked section are incorrect and indicate the wrong part of the file.
https://github.com/pagefaultgames/rogueserver?tab=readme-ov-file#srcutilsts224-225-in-pokerogue
I've already submitted a PR to fix this, right here: #45

@KuramiWan
Copy link

I noticed that the line number has changed again. Maybe it is better to modify Vite environment configuration in .env.production.

VITE_SERVER_URL=https://api.pokerogue.net

@amuck-gorilla
Copy link
Author

@KuramiWan Maybe it is better, I don't know. I've kind of let this PR fall by the wayside, since I found out on the Discord that Pancakes is busy and this probably isn't going to be addressed anytime soon. I don't care enough about this issue to keep the PR up-to-date for that long. Feel free to open your own PR, but I'm honestly considering whether to delete my PR or just update it when Pancakes is eventually available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants