Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan for next release - v2.0 #2451

Open
16 of 18 tasks
samuelhwilliams opened this issue Jul 15, 2024 · 32 comments
Open
16 of 18 tasks

Plan for next release - v2.0 #2451

samuelhwilliams opened this issue Jul 15, 2024 · 32 comments
Assignees

Comments

@samuelhwilliams
Copy link
Contributor

samuelhwilliams commented Jul 15, 2024

Opening this to think about/plan for the next release, which I propose should encompass:

Plus these changes merged since:

Plus these target changes:

And potentially any other small PRs we think we can get in fairly easily.

When the changeset is locked


Because of those last target changes, we'd need to do this as a major version bump.

@aenglander @Abdur-rahmaanJ - thoughts?

@samuelhwilliams samuelhwilliams changed the title Plan for next release - v2.0? Plan for next release - v2.0 Jul 16, 2024
@Abdur-rahmaanJ
Copy link
Member

@samuelhwilliams How about 1.7?

@samuelhwilliams
Copy link
Contributor Author

What makes you suggest 1.7?

I think standard practice would be to assume Semantic Versioning, which says breaking changes should be a major versioning bump (ie 1 to 2). Dropping python 3.7 and dropping flask-babelex are breaking changes, so I think V2 would be the logical step to me.

Happy to hear counter arguments though.

@Abdur-rahmaanJ
Copy link
Member

Good then did not see any breaking changes from the description. Good 👍 for a 2.0.

@hasansezertasan
Copy link
Member

I believe #2407 is suitable for the next release.

@samuelhwilliams
Copy link
Contributor Author

samuelhwilliams commented Jul 18, 2024

Flask-Babel and host_matching PRs are up. Will leave open for feedback for a few days.

Aiming to do a 2.0.0rc0 release next week ish.

@samuelhwilliams
Copy link
Contributor Author

Right. We have a bunch of stuff merged - I'm thinking of doing a 2.0.0rc0 release, maybe tomorrow. That would mean (in my head) no more feature merges - only bug fix merges - until 2.0.0 proper is released.

Do we think we want to try to get anything else simple/quick in urgently before the rc0 release?

@samuelhwilliams samuelhwilliams self-assigned this Jul 23, 2024
@samuelhwilliams
Copy link
Contributor Author

@cjmayo Have added SQLAlchemy 2/Flask 3/WTForms 3 as target changes for a 2.0.0 release, if you're happy with that? I'm happy to try to help where needed, although it looks like maybe you've got it covered.

@samuelhwilliams samuelhwilliams pinned this issue Jul 23, 2024
@princerb
Copy link
Contributor

princerb commented Jul 24, 2024

There are more configuration changes too, like when creating Admin instance, so I guess it is fair to think about the next release tagging with 2.0.0

@cjmayo
Copy link
Contributor

cjmayo commented Jul 24, 2024

@cjmayo Have added SQLAlchemy 2/Flask 3/WTForms 3 as target changes for a 2.0.0 release, if you're happy with that? I'm happy to try to help where needed, although it looks like maybe you've got it covered.

I'm happy. I think I have enough - at least to get the tests to pass (I have been using these patches for a while with the new dependencies).

@samuelhwilliams
Copy link
Contributor Author

Would you like to weigh in/mind weighing in on #2476? It deals with dependencies too, specifically making it more explicit what dependencies are required for certain features and what versions we support. It doesn't do much work bumping dependencies, but should make it easier to test+validate dep bumps in the future.

@samuelhwilliams
Copy link
Contributor Author

samuelhwilliams commented Jul 30, 2024

Ok - the target date is obviously slipping a bit, but I think it's useful to get a few more of these things in before doing some kind of pre-release.

Notably:

@ElLorans
Copy link
Contributor

ElLorans commented Aug 4, 2024

Can we have in the docs a suggested approach for considering client's timezone when submitting datetime fields? I am referring to #1892

@samuelhwilliams
Copy link
Contributor Author

samuelhwilliams commented Aug 7, 2024

@ElLorans would you like to put up a PR adding some information and/or an example? I think specifically an example would be super helpful :)

@ElLorans
Copy link
Contributor

ElLorans commented Aug 8, 2024

@samuelhwilliams just opened #2502

@samuelhwilliams
Copy link
Contributor Author

Since the changes merged so far for v2.0.0 include a lot of dependency bumps, I think it also makes sense to switch the S3 admin interface over from using boto to boto3, and the azure-blob-storage interface to using azure-storage-blob>=12. So will try to include those as well.

@pajusmar
Copy link

Thank you for all the hard work on the new release. I noticed that while there are many exciting updates mentioned, there hasn't been any discussion about the state of translations. There was an earlier issue (#1950) that raised concerns about updating translations, and I was wondering if this has been addressed in the latest release or if there are any plans to do so.

@samuelhwilliams
Copy link
Contributor Author

Hey @pajusmar - it's a good question. I've asked it on the pallets-eco discord to work out what our plan is with translations... 👀

@samuelhwilliams
Copy link
Contributor Author

Going to publish v2.0.0a0 shortly - this is an pre-release so would be grateful to anyone able to test it out and see what bugs there may be 🙏

It's not feature-complete yet necessarily, and I still think it'd be nice to get updates to fileadmin for AWS and Azure in, but I just haven't had time yet. Anyone able to contribute those changes (essentially migrating fileadmin.s3 to use boto3, and updating fileadmin.azure to use azure-storage-blob>=12)

@samuelhwilliams
Copy link
Contributor Author

v2.0.0a0 is now published

@pajusmar
Copy link

pajusmar commented Sep 6, 2024

Hey @pajusmar - it's a good question. I've asked it on the pallets-eco discord to work out what our plan is with translations... 👀

@samuelhwilliams, I saw on Discord that I should submit a pull request to modify translations.

I would really like to change one word. "Add" is a verb, not a noun, as it's currently translated into Estonian. The correct translation is "Lisa". Will it make it to 2.0, or are we past the string freeze?

@samuelhwilliams
Copy link
Contributor Author

Nope, by all means put up a PR please. Changes now would still go into V2.0.0 :)

@LeXofLeviafan
Copy link
Contributor

Out of curiosity – is there any progress on #1974? (Or at least any information about its causes?)

It just seems kind of bizarre that "View record" & "Edit record" button tooltips are translated, but "Delete record" is not 😅

@ElLorans
Copy link
Contributor

Out of curiosity – is there any progress on #1974? (Or at least any information about its causes?)

It just seems kind of bizarre that "View record" & "Edit record" button tooltips are translated, but "Delete record" is not 😅

Yes that's annoying for sure

@ElLorans
Copy link
Contributor

Out of curiosity – is there any progress on #1974? (Or at least any information about its causes?)

It just seems kind of bizarre that "View record" & "Edit record" button tooltips are translated, but "Delete record" is not 😅

This is fixed in #2526 (comment) . @samuelhwilliams can we release 2.0? Are there still DeprecationWarnings?

@samuelhwilliams
Copy link
Contributor Author

samuelhwilliams commented Oct 11, 2024

I will (try to) do a 2.0.0a1 soon. I think there's probably still more stuff that makes sense to do for a 'proper' v2 release - updating both of the fileadmin implementations for a start.

@samuelhwilliams
Copy link
Contributor Author

I've done a v2.0.0a1 now that includes those changes and compatibility support for wtforms v3.2+

@samuelhwilliams
Copy link
Contributor Author

samuelhwilliams commented Oct 26, 2024

I do still think it would be good to get in updates for s3/ABS before doing an official release of v2.0.0, but I also am aware that it's taking quite a chunk of time for me to have time for that and there's maybe not a huge amount of appetite from anyone else to add it. :(

Possibly also good to drop python 3.8 and add python 3.13, too.

@samuelhwilliams
Copy link
Contributor Author

Ok I found time to do boto->boto3, so just azure blob storage to go really 🤞

@samuelhwilliams
Copy link
Contributor Author

that's now available as v2.0.0a2

@pamelafox
Copy link
Contributor

@samuelhwilliams Is there an issue about azure blob storage? I can probably tackle that. Just wondering if there were known issues about upgrading, or just general SDK interface changes.

@samuelhwilliams
Copy link
Contributor Author

I'm not aware of any issues specifically - but that is mostly because I haven't looked closely yet. It may well just be SDK interface changes. Would be very grateful if you wanted to tackle it, it's really the last big blocker for an official v2 release, I think 👀

If there isn't an obvious issue open, please feel free to open one to track it 🙏

@pamelafox
Copy link
Contributor

PR for Azure storage upgrade: https://github.com/pallets-eco/flask-admin/pull/2573/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

9 participants