Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SessionMiddleware should use secure cookie to store session id #5

Open
davidism opened this issue Feb 25, 2020 · 1 comment
Open

SessionMiddleware should use secure cookie to store session id #5

davidism opened this issue Feb 25, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@davidism
Copy link
Member

No description provided.

@davidism
Copy link
Member Author

Laid some groundwork for this in the 0.1.0 release. Extracted the cookie parse and dump logic from __call__ into separate private methods. That way if a project needs to still load existing plain cookies (why?), they can override _get_session_id to try that if loading a signed cookie fails.

@davidism davidism added this to the 1.0.0 milestone Feb 26, 2020
@northernSage northernSage added the enhancement New feature or request label Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@davidism @northernSage