Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sources after Java to Kotlin conversion #534

Closed
dzikoysk opened this issue Oct 3, 2020 · 6 comments · Fixed by #536
Closed

Refactor sources after Java to Kotlin conversion #534

dzikoysk opened this issue Oct 3, 2020 · 6 comments · Fixed by #536
Labels
backend cleanup hacktoberfest help wanted

Comments

@dzikoysk
Copy link
Member

dzikoysk commented Oct 3, 2020

No description provided.

@junlarsen
Copy link
Contributor

Hi, I wouldn't mind looking into this, could you elaborate on what has to be done?

Judging from the title I assume we want a more idiomatic kotlin approach to the codebase.

@dzikoysk
Copy link
Member Author

dzikoysk commented Oct 4, 2020

Yeah, the sources (hub-backend) are pretty dirty after conversion from Java. There is a lot of unnecessary operations which can be replaced with a standard Kotlin features. The task is to just review these classes and refactor them, it does not require much of knowledge about the project and its logic - it is why it should be quite achievable for newcomers :)

@junlarsen
Copy link
Contributor

junlarsen commented Oct 5, 2020 •
edited
Loading

Okay cool, I'll have a look at it later today and submit a patch for review.

Do you guys have any preferences in terms of codestyle? Perhaps you'd be interested in ktlint which is an excellent linter for Kotlin? I'd be more than happy to set it up.

@dzikoysk
Copy link
Member Author

dzikoysk commented Oct 5, 2020

I'm not familiar with a standard kotlin based web stack, but I've heard that ktlint is a pretty common solution here, so yeah... it might be a good idea to add it :)

@junlarsen junlarsen mentioned this issue Oct 5, 2020
Merged
dzikoysk pushed a commit that referenced this issue Oct 5, 2020
@junlarsen
GH-534 Add ktlint for Kotlin and refactor codebase to utilize Kotlin …
efa3ebc 
…idioms (#536)

* GH-534 Add ktlint for Maven

* Run ktlint on entire codebase

* Refactor codebase into a more idiomatic kotlin approach

* Run ktlint

* Fix wildcard imports in old_tests
@dzikoysk
Copy link
Member Author

dzikoysk commented Oct 5, 2020

Related issue: #537

@dzikoysk dzikoysk reopened this Oct 5, 2020
@dzikoysk
Copy link
Member Author

#638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend cleanup hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-534 Add ktlint for Kotlin and refactor codebase to utilize Kotlin idioms
2 participants
@dzikoysk @junlarsen