Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observations from playing with this #50

Open
jserrao opened this issue Dec 7, 2017 · 1 comment
Open

Observations from playing with this #50

jserrao opened this issue Dec 7, 2017 · 1 comment

Comments

@jserrao
Copy link

jserrao commented Dec 7, 2017

Just thought I'd provide some feedback for you all.

-First of all, this documentation is class leading: https://pantheon.io/docs/guides/build-tools/ - a fantastic walk-through that made setting this up clear. Huge leaps up from a lot of the other Pantheon documentation I've read.

-The CLI prompt on installation says, Enter a password you would like to use to log in to your test site. That language seems outdated (if you going to move this into a 1.x release and was confusing, as I wasn't sure this was my root WP user pw.

-Using this release ties into empty-wordpress upstream it looks like. I guess that's ok as this is a test bed but is a bit weird because I didn't have access to that upstream and was trying to bump up to 4.9.x. Might want to make note of that somewhere in the docs.

-I pulled the entire stack down with Lando onto my local machine and saw good results. Seeing the Bedrock inspiration, I paired this install with the Roots.io Sage 9.x base theme which also has a composer dependency, and pushed everything back into pantheon. Things worked well there.

-The .gitignore file is pretty complex for this project, could use some documentation on what's happening there.

I'm excited to see pantheon pushing WP into the future like this - let me know if I can be of help in testing / developing anything.

@dustinleblanc
Copy link

-Using this release ties into empty-wordpress upstream it looks like. I guess that's ok as this is a test bed but is a bit weird because I didn't have access to that upstream and was trying to bump up to 4.9.x. Might want to make note of that somewhere in the docs.

Using Composer requires decoupling from the upstream system, you have to use Composer to update core.

Good notes otherwise though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants