Unknown flag --python-repos-repos on global scope with older Pants versions

[thejcannon]

josh@cephandrius:~/work/splash$ cd $(mktemp -d)
josh@cephandrius:/tmp/tmp.MoI8b5oKpj$ touch pants.toml
josh@cephandrius:/tmp/tmp.MoI8b5oKpj$ touch BUILDROOT
josh@cephandrius:/tmp/tmp.MoI8b5oKpj$ PANTS_VERSION=2.0.2 pants --no-verify-config help-all
Unknown flag --python-repos-repos on global scope
Use `pants help` to get help.
10:38:18.20 [ERROR] Unknown flags --python-repos-repos on global scope

(Use --print-stacktrace to see more error details.)

Will test to see what version is "fixed"

[thejcannon]

Oddly... https://www.pantsbuild.org/v2.0/docs/reference-python-repos

So it might be some kind of options-parsing issue?

[thejcannon]

2.8.0 works, 2.7.2 doesn't

[thejcannon]

This may be moot, as we're soon going to remove PANTS_SHA support (likely in tandem with the 2.18 Pants release).

[kaos]

This may be moot, as we're soon going to remove PANTS_SHA support (likely in tandem with the 2.18 Pants release).

How is this related to the PANTS_SHA support?

[thejcannon]

Yeah, I don't remember...

[kaos]

why are there so limited emoji reactions.. I wanted a 😢 one..

[huonw]

I suspect the discussion may've moved on with the changes in #351, but the code that adds this argument explicitly calls out PANTS_SHA:

scie-pants/tools/src/scie_pants/pants_version.py

Lines 37 to 51 in 8dc8d41

	def pants_find_links_option(self, pants_version_selected: Version) -> str:
	# We only want to add the find-links repo for PANTS_SHA invocations so that plugins can
	# resolve Pants the only place it can be found in that case - our ~private
	# binaries.pantsbuild.org S3 find-links bucket.
	operator = "-" if pants_version_selected == self.stable_version else "+"
	option_name = (
	"repos"
	if self.stable_version in SpecifierSet("<2.14.0", prereleases=True)
	else "find-links"
	)
	value = f"'{self.find_links}'" if self.find_links else ""
	# we usually pass a no-op, e.g. --python-repos-find-links=-[], because this is only used for
	# PANTS_SHA support that is now deprecated and will be removed
	return f"--python-repos-{option_name}={operator}[{value}]"