-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove constraint of hardcoded RPC tx type #10450
Comments
emhane
added
S-blocked
This cannot more forward until something else changes
C-debt
Refactor of code section that is hard to understand or maintain
A-rpc
Related to the RPC implementation
labels
Aug 22, 2024
@emhane assign me |
appreciate the enthusiasm @malik672 , but this one is blocked, so won't assign anyone until it becomes unblocked |
It seems that it becomes unblocked. Maybe can assign malik672 |
@nkysg nah, you do it |
thanks for heads up @nkysg |
emhane
removed
the
S-blocked
This cannot more forward until something else changes
label
Aug 30, 2024
closed by #9774 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature
Remove constraint that
alloy_network::Network::TransactionResponse
must be typereth_rpc_types::Transaction
.This depends on new alloy release, for example extending all
alloy_rpc_types_eth::SubscriptionResult
implementations from defaultSubscriptionResult
to generic over transactionSubscriptionResult<T>
.reth/crates/rpc/rpc-eth-api/src/types.rs
Lines 21 to 23 in 7d8196e
Additional context
No response
The text was updated successfully, but these errors were encountered: