Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Optimism naming #12192

Closed
mattsse opened this issue Oct 30, 2024 · 5 comments
Closed

Unify Optimism naming #12192

mattsse opened this issue Oct 30, 2024 · 5 comments
Assignees
@stevencartavia
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 30, 2024

Describe the feature

op-alloy settled on Op prefix, our crates still use Optimism

we should rename our types here to Op as well.

this should happen type by type, e.g: OptimismPayloadBuilderAttributes -> OpPayloadBuilderAttributes

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Oct 30, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Oct 30, 2024
@stevencartavia
Copy link
Contributor

🙋🏽‍♂️

@mattsse
Copy link
Collaborator Author

mattsse commented Oct 30, 2024

cool, let's wait until this pr is merged:

#11887

@mattsse
Copy link
Collaborator Author

mattsse commented Oct 30, 2024

@stevencartavia if you want, you can also look into alloy-rs/op-alloy#204

@stevencartavia
Copy link
Contributor

@stevencartavia if you want, you can also look into alloy-rs/op-alloy#204

sure! :)

This was referenced Oct 30, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 6, 2024
Merged
Merged
Merged
This was referenced Nov 7, 2024
Merged
Merged
Merged
@mattsse
Copy link
Collaborator Author

mattsse commented Nov 13, 2024

marking this as completed thansk @stevencartavia

@mattsse mattsse closed this as completed Nov 13, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevencartavia stevencartavia

Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

renamed types to Op stevencartavia/reth
2 participants
@mattsse @stevencartavia