Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace BuilderBlockValidationRequestV3 with alloy type #12251

Closed
Tracked by #12576
mattsse opened this issue Nov 1, 2024 · 2 comments · Fixed by #12396
Closed
Tracked by #12576

replace BuilderBlockValidationRequestV3 with alloy type #12251

mattsse opened this issue Nov 1, 2024 · 2 comments · Fixed by #12396
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request S-blocked This cannot more forward until something else changes

Comments

@mattsse
Copy link
Collaborator

mattsse commented Nov 1, 2024

Describe the feature

TODO

replace

reth/crates/rpc/rpc-api/src/validation.rs

Lines 11 to 16 in 8d31b65

/// A Request to validate a [`SignedBidSubmissionV3`]
///
/// <https://github.com/flashbots/builder/blob/7577ac81da21e760ec6693637ce2a81fe58ac9f8/eth/block-validation/api.go#L198-L202>
#[serde_as]
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
pub struct BuilderBlockValidationRequestV3 {

after we've bumped alloy

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-blocked This cannot more forward until something else changes A-rpc Related to the RPC implementation labels Nov 1, 2024
@Paulius0112
Copy link
Contributor

Hi @mattsse , can I work on this?

@mattsse
Copy link
Collaborator Author

mattsse commented Nov 3, 2024

sure, but this is blocked until #12215

@stevencartavia stevencartavia mentioned this issue Nov 8, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Nov 8, 2024
@emhane emhane mentioned this issue Nov 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request S-blocked This cannot more forward until something else changes
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace BuilderBlockValidationRequestV3 with alloy type stevencartavia/reth
2 participants
@mattsse @Paulius0112