Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce rayon feature in trie-common #14091

Closed
Tracked by #13951
mattsse opened this issue Jan 30, 2025 · 1 comment
Closed
Tracked by #13951

Introduce rayon feature in trie-common #14091

mattsse opened this issue Jan 30, 2025 · 1 comment
Assignees
@DarkLord017
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jan 30, 2025 •
edited
Loading

ref #13443

this is baking in rayon in public API:

reth/crates/trie/trie/src/state.rs

Lines 31 to 33 in 2216c8a

pub fn from_bundle_state<'a, KH: KeyHasher>(
state: impl IntoParallelIterator<Item = (&'a Address, &'a BundleAccount)>,
) -> Self {

we should do something like this here:

reth/crates/primitives-traits/src/transaction/recover.rs

Lines 9 to 10 in 2216c8a

#[cfg(feature = "rayon")]
mod rayon {

TODO

  • introduce a rayon feature
  • make functions mutually exclusive, one regular intoiter, one intoparallel
@mattsse mattsse mentioned this issue Jan 30, 2025
Open
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-sdk Related to reth's use as a library labels Jan 30, 2025
@DarkLord017
Copy link
Contributor

can i work on this issue @mattsse ?

DarkLord017 added a commit to DarkLord017/reth that referenced this issue Jan 30, 2025
@DarkLord017
Fix: Made parallelization optional using rayon (ref: paradigmxyz#14091)
d5ef7be
@DarkLord017 DarkLord017 mentioned this issue Jan 30, 2025
Closed
@mattsse mattsse closed this as completed Feb 6, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarkLord017 DarkLord017

Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @DarkLord017