Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-reth storage access is broken due to missing Deposit TxType #14407

Closed
1 task done
cakevm opened this issue Feb 11, 2025 · 4 comments
Closed
1 task done

op-reth storage access is broken due to missing Deposit TxType #14407

cakevm opened this issue Feb 11, 2025 · 4 comments
Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-bug An unexpected or incorrect behavior

Comments

@cakevm
Copy link
Contributor

cakevm commented Feb 11, 2025

Describe the bug

Starting a op-reth node results in:

2025-02-11T13:58:08.024714Z  INFO Verifying storage consistency.
thread 'main' panicked at crates/storage/codecs/src/alloy/transaction/txtype.rs:44:30:
Unsupported TxType identifier: 126

This issue is related to #14220.

Cause is PR #13830

In crates/primitives/src/transaction/tx_type.rsthe TxType was removed that contained:

pub enum TxType {
    ...
    /// Optimism Deposit transaction.
    #[cfg(feature = "optimism")]
    #[display("deposit (126)")] <-- missing in alloy_consensus
    Deposit = 126_isize,
    ...

This is now

pub use alloy_consensus::TxType; <-- missing op types

As a result in crates/storage/db-api/src/models/mod.rs the TxType is now from alloy_consensus and is missing the optimism types:

impl_compression_for_compact!(
    ...
    TxType
    ...
);

Steps to reproduce

Checkout 0f5d60, build op-reth and start it with existing db.

Node logs


Platform(s)

No response

Container Type

Not running in a container

What version/commit are you on?

0f5d60

What database version are you on?

Current database version: 2
Local database version: 2

Which chain / network are you on?

base

What type of node are you running?

Archive (default)

What prune config do you use, if any?

No response

If you've built Reth from source, provide the full command you used

make op-build

Code of Conduct

  • I agree to follow the Code of Conduct
@cakevm cakevm added C-bug An unexpected or incorrect behavior S-needs-triage This issue needs to be labelled labels Feb 11, 2025
@emhane emhane added A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library and removed S-needs-triage This issue needs to be labelled labels Feb 11, 2025
@BowTiedDevil
Copy link

I've been watching this one too — the latest tagged image (bae79ec) runs as expected via container, the TxType 126 panic is resolved.

@emhane
Copy link
Member

emhane commented Feb 11, 2025

op-reth main isn't working since #14209

advice running latest release if that is an option

@emhane emhane closed this as completed Feb 11, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 11, 2025
@emhane
Copy link
Member

emhane commented Feb 11, 2025

ah sorry, this is only if you're also testing latest hardfork, re-opening

@emhane emhane reopened this Feb 11, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Reth Tracker Feb 11, 2025
@cakevm
Copy link
Contributor Author

cakevm commented Feb 11, 2025

Thank you @BowTiedDevil, I tried with the latest commit version d727701 and it is now working as expected.

@cakevm cakevm closed this as completed Feb 11, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Feb 11, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Project Tracking Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-bug An unexpected or incorrect behavior
Projects
Status: Done
Development

No branches or pull requests

3 participants