Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v37 POLXY() in no longer working the same #5

Open
PropGit opened this issue Jan 16, 2023 · 2 comments
Open

v37 POLXY() in no longer working the same #5

PropGit opened this issue Jan 16, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@PropGit
Copy link
Contributor

PropGit commented Jan 16, 2023

POLXY() in v37 is reporting different values than an v36. This was reported for Propeller Tool but as it relates to the P2 compiler changes.

@PropGit PropGit added the bug Something isn't working label Jan 16, 2023
@PropGit
Copy link
Contributor Author

PropGit commented Jan 16, 2023

I verified that the Spin2 Interpreter code for POLXY(), ROTXY(), and XYPOL() was changed in v37. @ChipGracey will need to review and fix.

POLXY() is definitely affected; not sure if ROTXY() or XYPOL() is adversely affected or not.

@ChipGracey
Copy link
Contributor

Sorry about this. I had forgotten to use a #immediate in the interpreter when comparing which instruction we were executing. I've fixed this, but need to push it.

In the spin2_interpreter.spin2 file:

	cmp	pa,bc_polxy

...needs to become...

	cmp	pa,#bc_polxy

That will fix this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants