Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate XCMv3 #7807

Open
3 tasks
bkontur opened this issue Mar 5, 2025 · 5 comments
Open
3 tasks

Deprecate XCMv3 #7807

bkontur opened this issue Mar 5, 2025 · 5 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. T6-XCM This PR/Issue is related to XCM.

Comments

@bkontur
Copy link
Contributor

bkontur commented Mar 5, 2025

Now that we have XCMv5 released, we should deprecate XCMv3, similar to how we deprecated XCMv2 when we introduced XCMv4.

TODO

  • Deprecate XCMv3
  • Check, fix, or remove MIN_XCM_VERSION – see comment here
  • Backport to all stable2412 and stable2503 versions (should be fine, as Fellows has migrated to xcm::v4reference
@bkontur bkontur added the T6-XCM This PR/Issue is related to XCM. label Mar 5, 2025
@bkontur bkontur moved this to Todo in Bridges + XCM Mar 5, 2025
@bkontur bkontur added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Mar 5, 2025
@xlc
Copy link
Contributor

xlc commented Mar 5, 2025

why backport to existing stable versions?

@bkchr
Copy link
Member

bkchr commented Mar 5, 2025

Yeah and we should also not remove the code if not really needed.

@bkontur
Copy link
Contributor Author

bkontur commented Mar 5, 2025

why backport to existing stable versions?

my mistake - not to all, but only to those containing XCMv5 (stable2412, stable2503). I think we should backport Deprecate XCMv3 so that downstream users upgrade in advance (kind of forcing them to migrate to XCMv4 or XCMv5).

@franciscoaguirre Do we have documentation somewhere on adding new XCM versions and the deprecation process? I think I saw it "somewhere"?

Yeah and we should also not remove the code if not really needed.

MIN_XCM_VERSION was introduced/merged just last week, and I believe it is not really needed to expose it from xcm module.

@xlc
Copy link
Contributor

xlc commented Mar 5, 2025

Is there a v4 / v5 migration guide? I have no idea where to look up for guides.

I tried search v5 on this page and there is no result? https://github.com/paritytech/polkadot-sdk/releases?page=1

@programskillforverification
Copy link
Contributor

I would like to work on this. Please assign to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. T6-XCM This PR/Issue is related to XCM.
Projects
Status: No status
Status: Todo
Development

No branches or pull requests

4 participants