Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fork ID does almost nothing #11561

Closed
2 tasks done
nazar-pc opened this issue May 31, 2022 · 1 comment
Closed
2 tasks done

Fork ID does almost nothing #11561

nazar-pc opened this issue May 31, 2022 · 1 comment

Comments

@nazar-pc
Copy link
Contributor

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

There is a fork_id field in the chain spec with the following description:

/// Arbitrary string. Nodes will only synchronize with other nodes that have the same value
/// in their `fork_id`. This can be used in order to segregate nodes in cases when multiple
/// chains have the same genesis hash.
#[serde(default = "Default::default", skip_serializing_if = "Option::is_none")]
fork_id: Option<String>,

However this description is misleading because the only two components aware of this fork_id are beefy-gadget and sc-finality-grandpa. Nothing else in the whole Substrate cares about it even though as a feature it might be helpful at times.

Steps to reproduce

No response

@bkchr
Copy link
Member

bkchr commented May 31, 2022

This will be fixed by this issue: #7746

@bkchr bkchr closed this as completed May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants