Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscaling Passport under load #1528

Closed
Jkd-eth opened this issue Jul 31, 2023 · 6 comments
Closed

Autoscaling Passport under load #1528

Jkd-eth opened this issue Jul 31, 2023 · 6 comments
Assignees

Comments

@Jkd-eth
Copy link
Contributor

Jkd-eth commented Jul 31, 2023

User Story:

As a Passport PM or Dev
I want the system to be able auto scale under load
So that I can handle large partners driving large passports

Acceptance Criteria

GIVEN a partner implements Passport to protect their community
WHEN a large flood a new users comes in
THEN the system can automatically scale to support those users

Product & Design Links:

Tech Details:

Open Questions:

Notes/Assumptions:

@Jkd-eth Jkd-eth added this to Passport Jul 31, 2023
@Jkd-eth Jkd-eth moved this to Backlog in Passport Jul 31, 2023
@kammerdiener kammerdiener moved this from Backlog to In Progress (WIP) in Passport Aug 9, 2023
@kammerdiener
Copy link
Contributor

@erichfi getting focused on this one and will have some updates by tomorrow.

@kammerdiener
Copy link
Contributor

@Jeremy-Gitcoin // @erichfi

In looking at everything the current scaling parameters are fighting each other. What I would really recommend doing is swapping to just scaling based on CPU and Memory. Drop the ALB scaling metric.

This way we can set CPU and Mem to start scaling up at about 50 percent and set it to start scaling in around 30. This way when it spikes, gains some more space, and recalculates it won't immediately start scaling back in.

@erichfi
Copy link
Contributor

erichfi commented Aug 10, 2023

Hi @kammerdiener, thanks for the recommendation. Let's proceed with scaling based on CPU and Memory, dropping the ALB scaling metric. Setting the thresholds to scale up at 50% and scale in around 30% sounds good. Please make the necessary adjustments and keep us posted. If there are any other considerations, let us know.

@kammerdiener
Copy link
Contributor

@erichfi -- I will work on the adjustments to the Pulumi code and get it setup for review.

@kammerdiener
Copy link
Contributor

To provide an update prior to Monday. I am finalizing the changes and should have a PR open Tuesday morning.

@kammerdiener
Copy link
Contributor

PR is avaialble here: passportxyz/passport-scorer#355

I was mistaken on being able to set the scale in so I have slowed it down in an attempt to reduce overall thrashing.

@kammerdiener kammerdiener moved this from In Progress (WIP) to Product/UX Review in Passport Aug 15, 2023
@erichfi erichfi moved this from Product/UX Review to Ready to Deploy in Passport Aug 17, 2023
@erichfi erichfi closed this as completed Aug 17, 2023
@erichfi erichfi moved this from Ready to Deploy to Done in Passport Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants