Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll redirect hotfix #3201

Open
larisa17 opened this issue Jan 22, 2025 · 4 comments
Open

Scroll redirect hotfix #3201

larisa17 opened this issue Jan 22, 2025 · 4 comments
Assignees

Comments

@larisa17
Copy link
Collaborator

larisa17 commented Jan 22, 2025

As a hot-fix for scroll reported error the following redirects were added:

  • //check -> /check
  • //claim -> /claim

Add the CORS header was added.

Clarify with the scroll team to prettify / adjust the calls to the valid urls & undo the modifications.

see : https://discord.com/channels/1201910237238399006/1331755395739422872

@larisa17 larisa17 converted this from a draft issue Jan 22, 2025
@larisa17 larisa17 moved this from Prioritized to Blocked in Passport New Jan 22, 2025
@larisa17 larisa17 self-assigned this Jan 22, 2025
@Jkd-eth
Copy link
Contributor

Jkd-eth commented Jan 28, 2025

@larisa17 It looks like the Canvas UI was taken down. I think we can check again tomorrow and revert the changes here :)

@larisa17
Copy link
Collaborator Author

@Jkd-eth perfect , will revert the changes today

@nutrina
Copy link
Collaborator

nutrina commented Jan 29, 2025

@Jkd-eth this means that we can kill the service we have running in the BE for the scroll attestation, correct?

@Jkd-eth
Copy link
Contributor

Jkd-eth commented Jan 29, 2025

@nutrina yes, that would only work for people directly making calls to the contracts now that the UI has been removed.

@larisa17 larisa17 moved this from Blocked to In Progress (WIP) in Passport New Jan 30, 2025
@larisa17 larisa17 moved this from In Progress (WIP) to Blocked in Passport New Jan 30, 2025
@larisa17 larisa17 moved this from Blocked to In Progress (WIP) in Passport New Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress (WIP)
Development

No branches or pull requests

3 participants