Added check for token environment variable #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- since the previous "if" checks for the cli flag and sets the token, we can assume the environment variable should be set at this point. We then check for the environment variable and assume the token is not set at this point. - Likely a better solution. Changes to be committed: modified: cmd/mapper.go
- removed extra space in if statement Changes to be committed: modified: cmd/mapper.go
patrickeasters
requested changes
Oct 24, 2022
- Failure on missing ENV var, even if the token is present via the cli flag Changes to be committed: modified: cmd/mapper.go
|
This might be stale or just need to be closed off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Patrick, quick and dirty check to see if the environment variable exists.