Skip to content
This repository has been archived by the owner on Dec 10, 2019. It is now read-only.

The node tab no longer auto generates #23

Open
schubox opened this issue Feb 9, 2018 · 1 comment
Open

The node tab no longer auto generates #23

schubox opened this issue Feb 9, 2018 · 1 comment

Comments

@schubox
Copy link

schubox commented Feb 9, 2018

The tabs were added, and for the last two months when I added a corresponding file for my tabs it would publish the public version correctly, but now, it all of a sudden just ignores my source pattern files and does not render them as a public version. So the result is no content in the tabs I added.

It just says:
Cannot GET /patterns/public-pattern-directory/public-version-of-file.css?1518218532895

@c42705
Copy link

c42705 commented Mar 13, 2018

@bmuenzenmeyer same happen to me, but it renders the full HTML of the patternlab app.

laurenhamel added a commit to laurenhamel/plugin-node-tab that referenced this issue Jan 25, 2019
Fixes pattern-lab#23 and fixes pattern-lab#15. Rewrites `findTab` to synchronous check if a file exists. If found, the file is copied over to the public patterns folder, or if not found, and empty file is created in its place. Also refactors the JS for improved clarity. This also closes pattern-lab#22 by updating the README.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants