Skip to content
This repository has been archived by the owner on Dec 10, 2019. It is now read-only.

Adding this plugin, stops other plugins working #28

Open
juanfernandes opened this issue Sep 12, 2018 · 1 comment
Open

Adding this plugin, stops other plugins working #28

juanfernandes opened this issue Sep 12, 2018 · 1 comment

Comments

@juanfernandes
Copy link

Really having trouble being able to customise PL.

If I add the plugin-node-tab, sass stops working and so does plugin-node-uiextension

This is what I have in patterlab-config.json:

"plugins": {
"plugin-node-tab": {
"enabled": true,
"initialized": false,
"options": {
"tabsToAdd": ["CSS"]
}
},
"plugin-node-uiextension": {
"enabled": true,
"initialized": false,
"options": {
"stylesheets": [
"../../../css/pattern-scaffolding.css"
],
"navLinks": {
"before": [],
"after": []
},
"gearLinks": {
"before": [],
"beforeSearch": []
}
}
}
}

I'm using PL v2.12.0

Thanks in advance

@juanfernandes juanfernandes changed the title Adding this plugin, stops other plugins Adding this plugin, stops other plugins working Sep 12, 2018
@bmuenzenmeyer
Copy link
Member

see pattern-lab/patternlab-node#812

what I imagine is likely happening is a race-condition. they are really only working by accident, a by-product of poor architecting on my part. This was exposed in PL 3 testing.

I need to re-write plugins to support promises instead of events

I will not be backporting a fix to 2.X
Plugin support is basically the last big item in PL 3 and I can only focus on that with my limited bandwidth https://github.com/pattern-lab/patternlab-node/milestone/22

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants