Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make keyboard shortcuts optional #85

Open
bradfrost opened this issue Oct 9, 2017 · 3 comments
Open

Make keyboard shortcuts optional #85

bradfrost opened this issue Oct 9, 2017 · 3 comments

Comments

@bradfrost
Copy link
Member

Per this conversation: https://twitter.com/melaniersumner/status/917499349038358529

It might make sense to make keyboard shortcuts an optional feature rather than a built-in one. I personally don't use them, and it sounds like there are some accessibility issues that arise with them.

@bmuenzenmeyer, do you know if keyboard shortcuts are already configurable, or would that need built? If it needs built, I can think of an easy way to accomplish it.

@bradfrost bradfrost changed the title Make keyboard shortcuts configurable Make keyboard shortcuts optional Oct 9, 2017
@bradfrost
Copy link
Member Author

To clarify, I'm suggesting adding something like keyboardShortcuts: false | true as a config option. If we wanted to get extra crazy, we could let users define their own shortcuts.

@bmuenzenmeyer
Copy link
Member

@bradfrost

they are hard-coded and found within https://github.com/pattern-lab/styleguidekit-assets-default/blob/7942f01da25a9591a44f131971f3f3ad029dfca6/src/js/styleguide.js

search on jwerty.key

a config entry of any name can be used to conditionally bind all these calls

@bmuenzenmeyer
Copy link
Member

labeling spec writeup needed because if a new config entry is added, both PL Node and PHP need to expose it to the client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants